Re: [Qemu-devel] [v9 Patch 6/6]Qemu: raw posix implementation of reopen functions

2011-11-22 Thread Stefan Hajnoczi
On Tue, Nov 22, 2011 at 11:30 AM, supriya kannery wrote: > Stefan Hajnoczi wrote: >> >> On Tue, Nov 22, 2011 at 9:45 AM, supriya kannery >> wrote: >> >>> >>> supriya kannery wrote: >>> Stefan Hajnoczi wrote: > > On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery > wrote:

Re: [Qemu-devel] [v9 Patch 6/6]Qemu: raw posix implementation of reopen functions

2011-11-22 Thread supriya kannery
Stefan Hajnoczi wrote: On Tue, Nov 22, 2011 at 9:45 AM, supriya kannery wrote: supriya kannery wrote: Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: +} +if ((flags & BDRV_O_NOCACHE)) { +raw_rs->reopen_state

Re: [Qemu-devel] [v9 Patch 6/6]Qemu: raw posix implementation of reopen functions

2011-11-22 Thread Christoph Hellwig
On Tue, Nov 22, 2011 at 11:32:42AM +, Stefan Hajnoczi wrote: > Are you sure POSIX guarantees that O_DIRECT can be changed with > F_SETFL? I didn't find any statement in the specification. It is > possible that this code compiles but does not actually work on > non-Linux OSes. Did you run tes

Re: [Qemu-devel] [v9 Patch 6/6]Qemu: raw posix implementation of reopen functions

2011-11-22 Thread Stefan Hajnoczi
On Tue, Nov 22, 2011 at 9:45 AM, supriya kannery wrote: > supriya kannery wrote: >> >> Stefan Hajnoczi wrote: >>> >>> On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery >>> wrote: >>> +        } +        if ((flags & BDRV_O_NOCACHE)) { +            raw_rs->reopen_state.reopen_fl

Re: [Qemu-devel] [v9 Patch 6/6]Qemu: raw posix implementation of reopen functions

2011-11-22 Thread supriya kannery
supriya kannery wrote: Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: +} +if ((flags & BDRV_O_NOCACHE)) { +raw_rs->reopen_state.reopen_flags |= O_DIRECT; +} else { +raw_rs->reopen_state.reopen_flags &= ~O_DIRECT

Re: [Qemu-devel] [v9 Patch 6/6]Qemu: raw posix implementation of reopen functions

2011-11-21 Thread supriya kannery
Stefan Hajnoczi wrote: On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: +static int raw_reopen_prepare(BlockDriverState *bs, BDRVReopenState **prs, + int flags) +{ +BDRVRawReopenState *raw_rs = g_malloc0(sizeof(BDRVRawReopenState)); +BDRVRawState *

Re: [Qemu-devel] [v9 Patch 6/6]Qemu: raw posix implementation of reopen functions

2011-11-17 Thread Stefan Hajnoczi
On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery wrote: > +static int raw_reopen_prepare(BlockDriverState *bs, BDRVReopenState **prs, > +                              int flags) > +{ > +    BDRVRawReopenState *raw_rs = g_malloc0(sizeof(BDRVRawReopenState)); > +    BDRVRawState *s = bs->opaque; > +

[Qemu-devel] [v9 Patch 6/6]Qemu: raw posix implementation of reopen functions

2011-11-10 Thread Supriya Kannery
raw-posix driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery Index: qemu/block/raw.c === --- qemu.