Re: [Qemu-devel] [virtio-dev] [PATCH v18 0/2] virtio-crypto: virtio crypto device specification

2017-05-02 Thread Gonglei (Arei)
Hi Halil, Nice to see your feedback again :) > -Original Message- > From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Wednesday, May 03, 2017 5:55 AM > Subject: Re: [virtio-dev] [PATCH v18 0/2] virtio-crypto: virtio crypto device > specification > > > Hi Gonglei! > > I've st

Re: [Qemu-devel] [virtio-dev] [PATCH v18 0/2] virtio-crypto: virtio crypto device specification

2017-05-02 Thread Halil Pasic
Hi Gonglei! I've started reviewing but it's going to take some time because I've missed the previous version (vacation) and v16 was a long time ago, so I have to re-check and re-learn things. My first impression is, it reads much better that v16 but still has some space for improvement. One ide