Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-22 Thread Daniel P. Berrange
On Thu, Sep 22, 2016 at 10:36:45AM +0200, Markus Armbruster wrote: > "Lin Ma" writes: > > Markus Armbruster 2016/9/20 星期二 上午 1:13 >>> > >>Andreas Färber writes: > > Saving acceptable values of enumeration types into member description > > of ObjectProperty is a good idea. > > > > The mem

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-22 Thread Daniel P. Berrange
On Thu, Sep 22, 2016 at 02:03:39PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > > IMHO we should go further and leverage QAPI schema to auto-generate all > > the tedious boilerplate code for QOM objects > > > > eg, consider the crypto/secret.c object file. > > > > We could

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-22 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Sep 22, 2016 at 01:12:22PM +0200, Markus Armbruster wrote: >> "Daniel P. Berrange" writes: >> >> > On Thu, Sep 22, 2016 at 10:36:45AM +0200, Markus Armbruster wrote: >> >> Don't make up a description in user_creatable_help_func(), improve the >> >> descrip

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-22 Thread Daniel P. Berrange
On Thu, Sep 22, 2016 at 01:12:22PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Thu, Sep 22, 2016 at 10:36:45AM +0200, Markus Armbruster wrote: > >> Don't make up a description in user_creatable_help_func(), improve the > >> description infrastructure and its use so you

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-22 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Sep 22, 2016 at 10:36:45AM +0200, Markus Armbruster wrote: >> Don't make up a description in user_creatable_help_func(), improve the >> description infrastructure and its use so you get more useful ones >> there. >> >> The existing description infrastructur

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-22 Thread Daniel P. Berrange
On Thu, Sep 22, 2016 at 10:36:45AM +0200, Markus Armbruster wrote: > Don't make up a description in user_creatable_help_func(), improve the > description infrastructure and its use so you get more useful ones > there. > > The existing description infrastructure is just Property member > descriptio

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-22 Thread Markus Armbruster
"Lin Ma" writes: Markus Armbruster 2016/9/20 星期二 上午 1:13 >>> >>Andreas Färber writes: >> >>> Hi Lin and Markus, >>> >>> Am 19.09.2016 um 13:58 schrieb Markus Armbruster: >>[...] You're messing with struct EnumProperty because you want more help than what ObjectPropertyInfo can pr

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-19 Thread Markus Armbruster
Andreas Färber writes: > Hi Lin and Markus, > > Am 19.09.2016 um 13:58 schrieb Markus Armbruster: [...] >> You're messing with struct EnumProperty because you want more help than >> what ObjectPropertyInfo can provice. >> >> Digression on the meaning of ObjectPropertyInfo. This is its >> defini

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-19 Thread Andreas Färber
Hi Lin and Markus, Am 19.09.2016 um 13:58 schrieb Markus Armbruster: > This is about QOM use. Cc: Andreas in case he has smart ideas. > Andreas, you may want to skip ahead to "EnumProperty". > > "Lin Ma" writes: > > Markus Armbruster 2016/9/12 星期一 下午 11:42 >>> >>> Lin Ma writes: >>>

Re: [Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-19 Thread Markus Armbruster
This is about QOM use. Cc: Andreas in case he has smart ideas. Andreas, you may want to skip ahead to "EnumProperty". "Lin Ma" writes: Markus Armbruster 2016/9/12 星期一 下午 11:42 >>> >>Lin Ma writes: >> >>> '-object help' prints available user creatable backends. >>> '-object $typename,help

[Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-17 Thread Lin Ma
>>> "Daniel P. Berrange" 2016/9/12 星期一 下午 11:56 >>> >On Sun, Sep 11, 2016 at 01:53:01PM +0800, Lin Ma wrote: >> '-object help' prints available user creatable backends. >> '-object $typename,help' prints relevant properties. >> >> Signed-off-by: Lin Ma >> --- >> include/qom/object_interfaces.

[Qemu-devel] 答复: Re: [PATCH v2] object: Add 'help' option for all available backends and properties

2016-09-17 Thread Lin Ma
>>> Markus Armbruster 2016/9/12 星期一 下午 11:42 >>> >Lin Ma writes: > >> '-object help' prints available user creatable backends. >> '-object $typename,help' prints relevant properties. >> >> Signed-off-by: Lin Ma >> --- >> include/qom/object_interfaces.h | 2 + >> qemu-options.hx