Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-23 Thread zhanghailiang
On 2015/6/23 15:50, Markus Armbruster wrote: zhanghailiang writes: On 2015/6/19 16:11, Markus Armbruster wrote: [...] To avoid the ugliness, we could change the QAPI generator. Currently, { 'command': 'migrate-set-parameters', 'data': 'MigrationParameters' } generates the sa

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-23 Thread Markus Armbruster
zhanghailiang writes: > On 2015/6/19 16:11, Markus Armbruster wrote: [...] >> To avoid the ugliness, we could change the QAPI generator. Currently, >> >> { 'command': 'migrate-set-parameters', >>'data': 'MigrationParameters' } >> >> generates the same interface as when you inline Mi

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-22 Thread zhanghailiang
On 2015/6/19 16:11, Markus Armbruster wrote: zhanghailiang writes: Hi, Is there any news about this discussion? Is anyone working on it? ;) Since the 'hard feature freeze' time is closer, we'd better to fix it in 2.4 before libvirt uses it. I have sent a RFC patch "[RFC] migration: Re-imple

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-19 Thread Markus Armbruster
zhanghailiang writes: > Hi, > > Is there any news about this discussion? > Is anyone working on it? ;) > > Since the 'hard feature freeze' time is closer, we'd better to fix it in 2.4 > before libvirt uses it. > > I have sent a RFC patch "[RFC] migration: Re-implement > 'migrate-set-parameters'

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-17 Thread zhanghailiang
Hi, Is there any news about this discussion? Is anyone working on it? ;) Since the 'hard feature freeze' time is closer, we'd better to fix it in 2.4 before libvirt uses it. I have sent a RFC patch "[RFC] migration: Re-implement 'migrate-set-parameters' to make it easily for extension" http://

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-08 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Eric Blake (ebl...@redhat.com) wrote: >> >> On 06/05/2015 03:50 AM, Dr. David Alan Gilbert wrote: >> >> > Hi, >> >> > Is there any way that we could make it easier t

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Eric Blake (ebl...@redhat.com) wrote: > >> On 06/05/2015 03:50 AM, Dr. David Alan Gilbert wrote: > >> > Hi, > >> > Is there any way that we could make it easier to add new migration > >> > parameters? The

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-08 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Eric Blake (ebl...@redhat.com) wrote: >> On 06/05/2015 03:50 AM, Dr. David Alan Gilbert wrote: >> > Hi, >> > Is there any way that we could make it easier to add new migration >> > parameters? The current way is complicated and error prone; >> > as far as I

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-05 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 06/05/2015 03:50 AM, Dr. David Alan Gilbert wrote: > > Hi, > > Is there any way that we could make it easier to add new migration > > parameters? The current way is complicated and error prone; > > as far as I can tell, to add a new parameter we need t

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-05 Thread Eric Blake
On 06/05/2015 03:50 AM, Dr. David Alan Gilbert wrote: > Hi, > Is there any way that we could make it easier to add new migration > parameters? The current way is complicated and error prone; > as far as I can tell, to add a new parameter we need to: > > 1) qapi-schema.json > a) Add to 'Mig

Re: [Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-05 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > Hi, > Is there any way that we could make it easier to add new migration > parameters? The current way is complicated and error prone; > as far as I can tell, to add a new parameter we need to: > > 1) qapi-schema.json > a) Add to 'Mig

[Qemu-devel] Adding new migration-parameters - any easier way?

2015-06-05 Thread Dr. David Alan Gilbert
Hi, Is there any way that we could make it easier to add new migration parameters? The current way is complicated and error prone; as far as I can tell, to add a new parameter we need to: 1) qapi-schema.json a) Add to 'MigrationParameter' enum, include comment b) Add to migrate-set-par