Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-22 Thread Ed Swierk
On Wed, Mar 22, 2017 at 2:19 AM, Fam Zheng wrote: > On Tue, 03/21 06:05, Ed Swierk wrote: >> Actually running snapshot_blkdev command in the text monitor doesn't >> trigger this assertion (I mixed up my notes). Instead it's triggered >> by the following sequence in qmp-shell: >> >> (QEMU) blockdev

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-22 Thread Fam Zheng
On Tue, 03/21 06:05, Ed Swierk wrote: > On Tue, Mar 21, 2017 at 5:50 AM, Fam Zheng wrote: > > On Tue, 03/21 05:20, Ed Swierk wrote: > >> On Mon, Mar 20, 2017 at 10:26 PM, Fam Zheng wrote: > >> > On Fri, 03/17 09:55, Ed Swierk wrote: > >> >> I'm running into the same problem taking an external sna

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-21 Thread Ed Swierk
On Tue, Mar 21, 2017 at 5:50 AM, Fam Zheng wrote: > On Tue, 03/21 05:20, Ed Swierk wrote: >> On Mon, Mar 20, 2017 at 10:26 PM, Fam Zheng wrote: >> > On Fri, 03/17 09:55, Ed Swierk wrote: >> >> I'm running into the same problem taking an external snapshot with a >> >> virtio-blk drive with iothrea

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-21 Thread Fam Zheng
On Tue, 03/21 05:20, Ed Swierk wrote: > On Mon, Mar 20, 2017 at 10:26 PM, Fam Zheng wrote: > > On Fri, 03/17 09:55, Ed Swierk wrote: > >> I'm running into the same problem taking an external snapshot with a > >> virtio-blk drive with iothread, so it's not specific to virtio-scsi. > >> Run a Linux

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-21 Thread Ed Swierk
On Mon, Mar 20, 2017 at 10:26 PM, Fam Zheng wrote: > On Fri, 03/17 09:55, Ed Swierk wrote: >> I'm running into the same problem taking an external snapshot with a >> virtio-blk drive with iothread, so it's not specific to virtio-scsi. >> Run a Linux guest on qemu master >> >> qemu-system-x86_64

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-20 Thread Fam Zheng
On Fri, 03/17 09:55, Ed Swierk wrote: > I'm running into the same problem taking an external snapshot with a > virtio-blk drive with iothread, so it's not specific to virtio-scsi. > Run a Linux guest on qemu master > > qemu-system-x86_64 -nographic -enable-kvm -monitor > telnet:0.0.0.0:1234,serv

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-20 Thread Ed Swierk
On Fri, Mar 17, 2017 at 12:27 PM, Paolo Bonzini wrote: > And this is a fix, but I have no idea why/how it works and what else it > may break. > > Patches 1 and 2 are pretty obvious and would be the first step towards > eliminating aio_disable/enable_external altogether. > > However I got patch 3 m

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-20 Thread Ed Swierk
On Fri, Mar 17, 2017 at 12:27 PM, Paolo Bonzini wrote: > And this is a fix, but I have no idea why/how it works and what else it > may break. > > Patches 1 and 2 are pretty obvious and would be the first step towards > eliminating aio_disable/enable_external altogether. > > However I got patch 3 m

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 18:32, Ed Swierk wrote: > On Fri, Mar 17, 2017 at 10:15 AM, Paolo Bonzini wrote: >> >> >> On 17/03/2017 18:11, Paolo Bonzini wrote: >>> >>> >>> On 17/03/2017 17:55, Ed Swierk wrote: I'm running into the same problem taking an external snapshot with a virtio-blk drive with

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 18:32, Ed Swierk wrote: > On Fri, Mar 17, 2017 at 10:15 AM, Paolo Bonzini wrote: >> >> >> On 17/03/2017 18:11, Paolo Bonzini wrote: >>> >>> >>> On 17/03/2017 17:55, Ed Swierk wrote: I'm running into the same problem taking an external snapshot with a virtio-blk drive with

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Ed Swierk
On Fri, Mar 17, 2017 at 10:15 AM, Paolo Bonzini wrote: > > > On 17/03/2017 18:11, Paolo Bonzini wrote: >> >> >> On 17/03/2017 17:55, Ed Swierk wrote: >>> I'm running into the same problem taking an external snapshot with a >>> virtio-blk drive with iothread, so it's not specific to virtio-scsi. >>

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 18:11, Paolo Bonzini wrote: > > > On 17/03/2017 17:55, Ed Swierk wrote: >> I'm running into the same problem taking an external snapshot with a >> virtio-blk drive with iothread, so it's not specific to virtio-scsi. >> Run a Linux guest on qemu master >> >> qemu-system-x86_64 -n

Re: [Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 17:55, Ed Swierk wrote: > I'm running into the same problem taking an external snapshot with a > virtio-blk drive with iothread, so it's not specific to virtio-scsi. > Run a Linux guest on qemu master > > qemu-system-x86_64 -nographic -enable-kvm -monitor > telnet:0.0.0.0:1234,se

[Qemu-devel] Assertion failure taking external snapshot with virtio drive + iothread

2017-03-17 Thread Ed Swierk
I'm running into the same problem taking an external snapshot with a virtio-blk drive with iothread, so it's not specific to virtio-scsi. Run a Linux guest on qemu master qemu-system-x86_64 -nographic -enable-kvm -monitor telnet:0.0.0.0:1234,server,nowait -m 1024 -object iothread,id=iothread1 -d