Re: [Qemu-devel] Block Filters

2013-09-16 Thread Fam Zheng
On Sun, 09/15 20:10, Benoît Canet wrote: Le Friday 06 Sep 2013 à 11:55:38 (+0200), Kevin Wolf a écrit : Am 06.09.2013 um 11:18 hat Fam Zheng geschrieben: On Fri, 09/06 10:45, Kevin Wolf wrote: Am 06.09.2013 um 09:56 hat Fam Zheng geschrieben: Since BlockDriver.bdrv_snapshot_create()

Re: [Qemu-devel] Block Filters

2013-09-16 Thread Benoît Canet
Le Monday 16 Sep 2013 à 15:41:45 (+0800), Fam Zheng a écrit : On Sun, 09/15 20:10, Benoît Canet wrote: Le Friday 06 Sep 2013 à 11:55:38 (+0200), Kevin Wolf a écrit : Am 06.09.2013 um 11:18 hat Fam Zheng geschrieben: On Fri, 09/06 10:45, Kevin Wolf wrote: Am 06.09.2013 um 09:56 hat

Re: [Qemu-devel] Block Filters

2013-09-16 Thread Benoît Canet
Le Monday 16 Sep 2013 à 15:41:45 (+0800), Fam Zheng a écrit : On Sun, 09/15 20:10, Benoît Canet wrote: Le Friday 06 Sep 2013 à 11:55:38 (+0200), Kevin Wolf a écrit : Am 06.09.2013 um 11:18 hat Fam Zheng geschrieben: On Fri, 09/06 10:45, Kevin Wolf wrote: Am 06.09.2013 um 09:56 hat

Re: [Qemu-devel] Block Filters

2013-09-15 Thread Benoît Canet
Le Friday 06 Sep 2013 à 11:55:38 (+0200), Kevin Wolf a écrit : Am 06.09.2013 um 11:18 hat Fam Zheng geschrieben: On Fri, 09/06 10:45, Kevin Wolf wrote: Am 06.09.2013 um 09:56 hat Fam Zheng geschrieben: Since BlockDriver.bdrv_snapshot_create() is an optional operation, blockdev.c

Re: [Qemu-devel] Block Filters

2013-09-06 Thread Kevin Wolf
Am 05.09.2013 um 19:29 hat Benoît Canet geschrieben: Le Thursday 05 Sep 2013 à 18:18:45 (+0800), Fam Zheng a écrit : On Thu, 09/05 12:01, Stefan Hajnoczi wrote: On Wed, Sep 04, 2013 at 08:15:36PM +0200, Benoît Canet wrote: Propagate operations like snapshot down the tree. block.c is

Re: [Qemu-devel] Block Filters

2013-09-06 Thread Fam Zheng
On Fri, 09/06 09:42, Kevin Wolf wrote: Am 05.09.2013 um 19:29 hat Benoît Canet geschrieben: Le Thursday 05 Sep 2013 à 18:18:45 (+0800), Fam Zheng a écrit : On Thu, 09/05 12:01, Stefan Hajnoczi wrote: On Wed, Sep 04, 2013 at 08:15:36PM +0200, Benoît Canet wrote: Propagate operations

Re: [Qemu-devel] Block Filters

2013-09-06 Thread Fam Zheng
On Tue, 09/03 18:24, Benoît Canet wrote: Hello list, I am thinking about QEMU block filters lately. I am not a block.c/blockdev.c expert so tell me what you think of the following. The use cases I see would be: -$user want to have some real cryptography on top of qcow2/qed or

Re: [Qemu-devel] Block Filters

2013-09-06 Thread Kevin Wolf
Am 06.09.2013 um 09:56 hat Fam Zheng geschrieben: On Tue, 09/03 18:24, Benoît Canet wrote: Hello list, I am thinking about QEMU block filters lately. I am not a block.c/blockdev.c expert so tell me what you think of the following. The use cases I see would be: -$user

Re: [Qemu-devel] Block Filters

2013-09-06 Thread Fam Zheng
On Fri, 09/06 10:45, Kevin Wolf wrote: Am 06.09.2013 um 09:56 hat Fam Zheng geschrieben: On Tue, 09/03 18:24, Benoît Canet wrote: Hello list, I am thinking about QEMU block filters lately. I am not a block.c/blockdev.c expert so tell me what you think of the following.

Re: [Qemu-devel] Block Filters

2013-09-06 Thread Kevin Wolf
Am 06.09.2013 um 11:18 hat Fam Zheng geschrieben: On Fri, 09/06 10:45, Kevin Wolf wrote: Am 06.09.2013 um 09:56 hat Fam Zheng geschrieben: Since BlockDriver.bdrv_snapshot_create() is an optional operation, blockdev.c can navigate down the tree from top node, until hitting some layer

Re: [Qemu-devel] Block Filters

2013-09-06 Thread Fam Zheng
On Fri, 09/06 11:55, Kevin Wolf wrote: Am 06.09.2013 um 11:18 hat Fam Zheng geschrieben: On Fri, 09/06 10:45, Kevin Wolf wrote: Am 06.09.2013 um 09:56 hat Fam Zheng geschrieben: Since BlockDriver.bdrv_snapshot_create() is an optional operation, blockdev.c can navigate down the

Re: [Qemu-devel] Block Filters

2013-09-05 Thread Kevin Wolf
Am 04.09.2013 um 20:15 hat Benoît Canet geschrieben: Propagate operations like snapshot down the tree. block.c is designed for bs-file/bs-backing_hd kind of BlockDrivers, perhaps it needs to become a bit more generic to support other types of BlockDrivers properly. Shouldn't

Re: [Qemu-devel] Block Filters

2013-09-05 Thread Stefan Hajnoczi
On Wed, Sep 04, 2013 at 08:15:36PM +0200, Benoît Canet wrote: Propagate operations like snapshot down the tree. block.c is designed for bs-file/bs-backing_hd kind of BlockDrivers, perhaps it needs to become a bit more generic to support other types of BlockDrivers properly. Shouldn't

Re: [Qemu-devel] Block Filters

2013-09-05 Thread Fam Zheng
On Thu, 09/05 12:01, Stefan Hajnoczi wrote: On Wed, Sep 04, 2013 at 08:15:36PM +0200, Benoît Canet wrote: Propagate operations like snapshot down the tree. block.c is designed for bs-file/bs-backing_hd kind of BlockDrivers, perhaps it needs to become a bit more generic to support other

Re: [Qemu-devel] Block Filters

2013-09-05 Thread Stefan Hajnoczi
On Thu, Sep 05, 2013 at 06:18:45PM +0800, Fam Zheng wrote: On Thu, 09/05 12:01, Stefan Hajnoczi wrote: On Wed, Sep 04, 2013 at 08:15:36PM +0200, Benoît Canet wrote: Propagate operations like snapshot down the tree. block.c is designed for bs-file/bs-backing_hd kind of BlockDrivers,

Re: [Qemu-devel] Block Filters

2013-09-05 Thread Benoît Canet
Le Thursday 05 Sep 2013 à 18:18:45 (+0800), Fam Zheng a écrit : On Thu, 09/05 12:01, Stefan Hajnoczi wrote: On Wed, Sep 04, 2013 at 08:15:36PM +0200, Benoît Canet wrote: Propagate operations like snapshot down the tree. block.c is designed for bs-file/bs-backing_hd kind of

Re: [Qemu-devel] Block Filters

2013-09-04 Thread Benoît Canet
Propagate operations like snapshot down the tree. block.c is designed for bs-file/bs-backing_hd kind of BlockDrivers, perhaps it needs to become a bit more generic to support other types of BlockDrivers properly. Shouldn't bs-backing_hd become bs-children[0] and bs-file stay the same ? Best

Re: [Qemu-devel] Block Filters

2013-09-04 Thread Stefan Hajnoczi
On Tue, Sep 03, 2013 at 06:24:49PM +0200, Benoît Canet wrote: -$user want to do Copy On Read This feature is currently implemented in the read code path in block.c. Putting it into a separate, stackable module is fine but may require a per-device request queue. Today every BDS has its own

[Qemu-devel] Block Filters

2013-09-03 Thread Benoît Canet
Hello list, I am thinking about QEMU block filters lately. I am not a block.c/blockdev.c expert so tell me what you think of the following. The use cases I see would be: -$user want to have some real cryptography on top of qcow2/qed or another format. snapshots and other block features