Re: [Qemu-devel] Bug in virtio_net_load

2016-07-04 Thread Robin Geuze
Hey, So over the weekend we did a bunch of migrations with a bunch of different guest OSes and such and it all worked fine, so I would say the patch is working properly :) Regards, Robin Geuze On 7/1/2016 10:48, Cornelia Huck wrote: On Thu, 30 Jun 2016 20:23:08 +0300 "Michael S. Tsirkin"

Re: [Qemu-devel] Bug in virtio_net_load

2016-07-01 Thread Robin Geuze
Hey Guys, We just tested the patch on QEMU 2.6.0 and confirmed that both 2.6.0 -> 2.6.0 and 2.4.0 -> 2.6.0 migrations work properly. We will be leaving a migration loop running over the weekend to verify that everything works as expected, but I don't expect any surprises from that. Thanks

Re: [Qemu-devel] Bug in virtio_net_load

2016-07-01 Thread Cornelia Huck
On Thu, 30 Jun 2016 20:23:08 +0300 "Michael S. Tsirkin" wrote: > I'm not sure what was I thinking when I applied this: > it changes load without changing save - how can this work? The ordering implications are easy to miss :( > I am inclined to revert

Re: [Qemu-devel] Bug in virtio_net_load

2016-06-30 Thread Jason Wang
On 2016年07月01日 01:23, Michael S. Tsirkin wrote: On Thu, Jun 30, 2016 at 10:34:51AM +0200, Robin Geuze wrote: Hey, I work for TransIP and we host a VPS platform based on QEMU/KVM. We are currently running qemu 2.4.0. A few days ago we noticed that live migrations for some of our VM's would

Re: [Qemu-devel] Bug in virtio_net_load

2016-06-30 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Jun 30, 2016 at 10:34:51AM +0200, Robin Geuze wrote: > > Hey, > > > > I work for TransIP and we host a VPS platform based on QEMU/KVM. We are > > currently running qemu 2.4.0. A few days ago we noticed that live migrations > > for some of

Re: [Qemu-devel] Bug in virtio_net_load

2016-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2016 at 10:34:51AM +0200, Robin Geuze wrote: > Hey, > > I work for TransIP and we host a VPS platform based on QEMU/KVM. We are > currently running qemu 2.4.0. A few days ago we noticed that live migrations > for some of our VM's would fail. Further investigation turned out it was

[Qemu-devel] Bug in virtio_net_load

2016-06-30 Thread Robin Geuze
Hey, I work for TransIP and we host a VPS platform based on QEMU/KVM. We are currently running qemu 2.4.0. A few days ago we noticed that live migrations for some of our VM's would fail. Further investigation turned out it was specific to windows server 2012, caused by the fact that the