Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Paolo Bonzini
Il 11/02/2014 19:57, Anthony Liguori ha scritto: > Erm, sorry, that is already implemented in qemu.git!? instance_post_init > by Eduardo plus glue by me. Ah, even better then :-) Still, the code is a bit ad hoc. Static properties would let us remove that code and just read dc->props arrays a

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Anthony Liguori
On Tue, Feb 11, 2014 at 8:55 AM, Andreas Färber wrote: > Am 11.02.2014 16:58, schrieb Anthony Liguori: >> On Tue, Feb 11, 2014 at 7:25 AM, Eduardo Habkost wrote: >>> On Tue, Feb 11, 2014 at 06:31:35AM -0800, Anthony Liguori wrote: On Fri, Feb 7, 2014 at 2:55 AM, Paolo Bonzini wrote: > I

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Andreas Färber
Am 11.02.2014 16:58, schrieb Anthony Liguori: > On Tue, Feb 11, 2014 at 7:25 AM, Eduardo Habkost wrote: >> On Tue, Feb 11, 2014 at 06:31:35AM -0800, Anthony Liguori wrote: >>> On Fri, Feb 7, 2014 at 2:55 AM, Paolo Bonzini wrote: Il 07/02/2014 11:16, Eduardo Habkost ha scritto: > You

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Paolo Bonzini
Il 11/02/2014 17:43, Eduardo Habkost ha scritto: > But compat properties as a concept could be made to work with dynamic > properties. They would have to be evaluated after instance init. > There's quite a few places they would end up touching I suspect. They already work. But if they work by

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Eduardo Habkost
On Tue, Feb 11, 2014 at 07:58:30AM -0800, Anthony Liguori wrote: > On Tue, Feb 11, 2014 at 7:25 AM, Eduardo Habkost wrote: > > On Tue, Feb 11, 2014 at 06:31:35AM -0800, Anthony Liguori wrote: > >> On Fri, Feb 7, 2014 at 2:55 AM, Paolo Bonzini wrote: > >> > Il 07/02/2014 11:16, Eduardo Habkost ha

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Anthony Liguori
On Tue, Feb 11, 2014 at 7:25 AM, Eduardo Habkost wrote: > On Tue, Feb 11, 2014 at 06:31:35AM -0800, Anthony Liguori wrote: >> On Fri, Feb 7, 2014 at 2:55 AM, Paolo Bonzini wrote: >> > Il 07/02/2014 11:16, Eduardo Habkost ha scritto: >> > >> >> You are not alone. I remember we spent lots of time t

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Eduardo Habkost
On Tue, Feb 11, 2014 at 06:31:35AM -0800, Anthony Liguori wrote: > On Fri, Feb 7, 2014 at 2:55 AM, Paolo Bonzini wrote: > > Il 07/02/2014 11:16, Eduardo Habkost ha scritto: > > > >> You are not alone. I remember we spent lots of time trying to convince > >> Anthony to allow global properties and c

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Anthony Liguori
On Fri, Feb 7, 2014 at 2:55 AM, Paolo Bonzini wrote: > Il 07/02/2014 11:16, Eduardo Habkost ha scritto: > >> You are not alone. I remember we spent lots of time trying to convince >> Anthony to allow global properties and compat_props affect dynamic >> properties not just static properties, and st

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Eduardo Habkost
On Fri, Feb 07, 2014 at 11:55:25AM +0100, Paolo Bonzini wrote: > Il 07/02/2014 11:16, Eduardo Habkost ha scritto: > >You are not alone. I remember we spent lots of time trying to convince > >Anthony to allow global properties and compat_props affect dynamic > >properties not just static properties,

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-07 Thread Paolo Bonzini
Il 07/02/2014 11:16, Eduardo Habkost ha scritto: You are not alone. I remember we spent lots of time trying to convince Anthony to allow global properties and compat_props affect dynamic properties not just static properties, and static properties were a big deal due to reasons I didn't understan

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-07 Thread Eduardo Habkost
On Thu, Feb 06, 2014 at 05:57:38PM +0100, Andreas Färber wrote: [...] > >> If there's no relation between a CPU model named, e.g., "Haswell" and > >> the one on an Intel Haswell chip any more, then we should give them > >> artificial names like "qemu64"; I strongly believe that Haswell > >> definit

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-07 Thread Eduardo Habkost
On Thu, Feb 06, 2014 at 05:57:38PM +0100, Andreas Färber wrote: [...] > And it's true that we could in fact just instantiate the object for > -device foo,? - it's just that nobody wrote code for that. I didn't do > the original QOM conversion so I don't feel guilty, I don't normally use > -device f

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-06 Thread Andreas Färber
Am 06.02.2014 17:16, schrieb Eduardo Habkost: > (CCing libvir-list again, as this is continuing a discussion about a > subject that interests libvirt developers, from another thread.) > > On Thu, Feb 06, 2014 at 04:51:17PM +0100, Andreas Färber wrote: >> Am 06.02.2014 16:19, schrieb Igor Mammedov:

[Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-06 Thread Eduardo Habkost
(CCing libvir-list again, as this is continuing a discussion about a subject that interests libvirt developers, from another thread.) On Thu, Feb 06, 2014 at 04:51:17PM +0100, Andreas Färber wrote: > Am 06.02.2014 16:19, schrieb Igor Mammedov: > > On Wed, 5 Feb 2014 17:52:16 +0100 > > Igor Mammedo