Re: [Qemu-devel] DMA active hw_error

2011-12-28 Thread Peter Maydell
On 28 December 2011 06:44, Richard Cole wrote: > I'll have to learn quite a bit more about QEMU and arm before I'll be > able to contribute back any patches. I bought a beagle board today so > that at least is a start, being able to compare QEMU to some real > hardware. There's no beagle board mo

Re: [Qemu-devel] DMA active hw_error

2011-12-27 Thread Richard Cole
I'll have to learn quite a bit more about QEMU and arm before I'll be able to contribute back any patches. I bought a beagle board today so that at least is a start, being able to compare QEMU to some real hardware. Out of curiosity what is the testing strategy for QEMU. Does one simply write stan

Re: [Qemu-devel] DMA active hw_error

2011-12-27 Thread Peter Maydell
On 27 December 2011 03:21, Richard Cole wrote: > Another thing I don't understand is the code from this function >  switch(offset >> 2) >    case 0: >      // src address register > > but 0x100 >> 2 does not equal 0. Not even close. Maybe it should be > >  (offset - 0x100) >> 2? > > But that woul

Re: [Qemu-devel] DMA active hw_error

2011-12-27 Thread Peter Maydell
On 27 December 2011 14:33, Andreas Färber wrote: > Further down, this also looks odd: > >        if (s->conf & (PL080_CONF_M1 | PL080_CONF_M1)) { >            hw_error("pl080_write: Big-endian DMA not implemented\n"); >        } > > Maybe (..._M1 | ..._M2)? Yes, obvious typo. I've noticed that on

Re: [Qemu-devel] DMA active hw_error

2011-12-27 Thread Peter Maydell
On 27 December 2011 02:26, Richard Cole wrote: > I'm new to QEMU so this might be a rather naive question but why is > there a hw_error [in pl080_run]: I believe that hw_error() is basically there to say "the code for handling DMA is untested at best and unimplemented at worst". Linux doesn't use

Re: [Qemu-devel] DMA active hw_error

2011-12-27 Thread Andreas Färber
Am 27.12.2011 03:26, schrieb Richard Cole: > https://github.com/qemu/QEMU/blob/2ac711791b2e4aabc5e4046b7428727828c705eb/hw/pl080.c#L96 Further down, this also looks odd: if (s->conf & (PL080_CONF_M1 | PL080_CONF_M1)) { hw_error("pl080_write: Big-endian DMA not implemented\n");

Re: [Qemu-devel] DMA active hw_error

2011-12-26 Thread Richard Cole
Another thing I don't understand is the code from this function https://github.com/qemu/QEMU/blob/master/hw/pl080.c#L289 If I look here http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0218e/ch03s04s15.html it seems to suggest that the src register is located at: 0x100 offset

[Qemu-devel] DMA active hw_error

2011-12-26 Thread Richard Cole
I'm new to QEMU so this might be a rather naive question but why is there a hw_error here: https://github.com/qemu/QEMU/blob/2ac711791b2e4aabc5e4046b7428727828c705eb/hw/pl080.c#L96 It causes QEMU at least on my machine to abort. It would seem to make it so the rest of the function will never be e