Re: [Qemu-devel] Drainage in bdrv_replace_child_noperm()

2017-11-08 Thread Max Reitz
On 2017-11-07 06:21, Fam Zheng wrote: > On Mon, 11/06 19:49, Max Reitz wrote: [...] >> I have two ideas: >> >> One is to assume that (un-)draining a parent will always (un-)drain all >> children, including the one the (un-)drain comes from. This assumption >> seems wrong, see [1], but maybe it i

Re: [Qemu-devel] Drainage in bdrv_replace_child_noperm()

2017-11-06 Thread Fam Zheng
On Mon, 11/06 19:49, Max Reitz wrote: > Hi everyone, > > On my quest to fix some flaky iotests, I came to a bit of a halt on 129. > (Details: Its issue is that block jobs now generally ignore throttling > in a BB (because they use their own), so we have to add a throttle node > instead. However,

[Qemu-devel] Drainage in bdrv_replace_child_noperm()

2017-11-06 Thread Max Reitz
Hi everyone, On my quest to fix some flaky iotests, I came to a bit of a halt on 129. (Details: Its issue is that block jobs now generally ignore throttling in a BB (because they use their own), so we have to add a throttle node instead. However, when I added it, I got an abort.) My issue can b