Re: [Qemu-devel] Fwd: [RFC 2/4] qemu-socket: Allow custom socket options in socket_connect

2018-01-31 Thread Daniel P . Berrangé
On Wed, Jan 31, 2018 at 11:20:16PM +0800, Zihan Yang wrote: > Hi, Daniel > > >You've added all this extra functionality to pass arbitrary > >options, but then not used it in any of the later patches. > >We've been trying to remove complexity from this code, so > >I'm not in favour of adding new fu

[Qemu-devel] Fwd: [RFC 2/4] qemu-socket: Allow custom socket options in socket_connect

2018-01-31 Thread Zihan Yang
Hi, Daniel >You've added all this extra functionality to pass arbitrary >options, but then not used it in any of the later patches. >We've been trying to remove complexity from this code, so >I'm not in favour of adding new functionality that is not >even used. You are right, unused functionality