[Qemu-devel] How to introduce bs->node_name ?

2013-10-28 Thread Benoît Canet
Hi list, After a discussion on irc we have two potential solution in order to introduce a new bs->node_name member in order to be able to manipulate the graph from the monitors. The first one is to make the QMP device parameter of the block commands optional and add the node-name parameter as a

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-10-28 Thread Fam Zheng
On Mon, 10/28 16:40, Benoît Canet wrote: > > Hi list, > > After a discussion on irc we have two potential solution in order to introduce > a new bs->node_name member in order to be able to manipulate the graph from > the > monitors. > > The first one is to make the QMP device parameter of the b

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-10-30 Thread Markus Armbruster
[Note cc: Eric & Luiz, because this also relates to QMP] Benoît Canet writes: > Hi list, > > After a discussion on irc we have two potential solution in order to introduce > a new bs->node_name member in order to be able to manipulate the graph from > the > monitors. > > The first one is to mak

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-10-30 Thread Eric Blake
On 10/30/2013 07:49 AM, Markus Armbruster wrote: > > The first proposal is to add another parameter, say "id". Users can > then refer either to an arbitrary BDS by "id", or (for backward > compatibility) to the root BDS by "device". When the code sees > "device", it'll look up the BB, then fetc

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-11-01 Thread Luiz Capitulino
On Wed, 30 Oct 2013 13:25:35 -0600 Eric Blake wrote: > On 10/30/2013 07:49 AM, Markus Armbruster wrote: > > > > > The first proposal is to add another parameter, say "id". Users can > > then refer either to an arbitrary BDS by "id", or (for backward > > compatibility) to the root BDS by "devic

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-11-01 Thread Eric Blake
On 11/01/2013 08:51 AM, Luiz Capitulino wrote: > On Wed, 30 Oct 2013 13:25:35 -0600 > Eric Blake wrote: > >> On 10/30/2013 07:49 AM, Markus Armbruster wrote: >> >>> >>> The first proposal is to add another parameter, say "id". Users can >>> then refer either to an arbitrary BDS by "id", or (for

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-11-01 Thread Luiz Capitulino
On Fri, 01 Nov 2013 08:59:20 -0600 Eric Blake wrote: > On 11/01/2013 08:51 AM, Luiz Capitulino wrote: > > On Wed, 30 Oct 2013 13:25:35 -0600 > > Eric Blake wrote: > > > >> On 10/30/2013 07:49 AM, Markus Armbruster wrote: > >> > >>> > >>> The first proposal is to add another parameter, say "id".

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-11-04 Thread Stefan Hajnoczi
On Wed, Oct 30, 2013 at 02:49:32PM +0100, Markus Armbruster wrote: > The first proposal is to add another parameter, say "id". Users can > then refer either to an arbitrary BDS by "id", or (for backward > compatibility) to the root BDS by "device". When the code sees > "device", it'll look up the

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-11-04 Thread Fam Zheng
On 11/04/2013 05:31 PM, Stefan Hajnoczi wrote: On Wed, Oct 30, 2013 at 02:49:32PM +0100, Markus Armbruster wrote: The first proposal is to add another parameter, say "id". Users can then refer either to an arbitrary BDS by "id", or (for backward compatibility) to the root BDS by "device". Whe

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-11-04 Thread Kevin Wolf
Am 04.11.2013 um 10:48 hat Fam Zheng geschrieben: > > On 11/04/2013 05:31 PM, Stefan Hajnoczi wrote: > >On Wed, Oct 30, 2013 at 02:49:32PM +0100, Markus Armbruster wrote: > >>The first proposal is to add another parameter, say "id". Users can > >>then refer either to an arbitrary BDS by "id", or

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-11-04 Thread Kevin Wolf
Am 01.11.2013 um 16:12 hat Luiz Capitulino geschrieben: > On Fri, 01 Nov 2013 08:59:20 -0600 > Eric Blake wrote: > > > On 11/01/2013 08:51 AM, Luiz Capitulino wrote: > > > On Wed, 30 Oct 2013 13:25:35 -0600 > > > Eric Blake wrote: > > > > > >> On 10/30/2013 07:49 AM, Markus Armbruster wrote: >

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-11-04 Thread Fam Zheng
On 11/04/2013 07:06 PM, Kevin Wolf wrote: Am 04.11.2013 um 10:48 hat Fam Zheng geschrieben: On 11/04/2013 05:31 PM, Stefan Hajnoczi wrote: On Wed, Oct 30, 2013 at 02:49:32PM +0100, Markus Armbruster wrote: The first proposal is to add another parameter, say "id". Users can then refer either

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-11-04 Thread Luiz Capitulino
On Mon, 4 Nov 2013 12:13:59 +0100 Kevin Wolf wrote: > Am 01.11.2013 um 16:12 hat Luiz Capitulino geschrieben: > > On Fri, 01 Nov 2013 08:59:20 -0600 > > Eric Blake wrote: > > > > > On 11/01/2013 08:51 AM, Luiz Capitulino wrote: > > > > On Wed, 30 Oct 2013 13:25:35 -0600 > > > > Eric Blake wrot

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-11-07 Thread Benoît Canet
Le Monday 04 Nov 2013 à 19:33:21 (+0800), Fam Zheng a écrit : > > On 11/04/2013 07:06 PM, Kevin Wolf wrote: > >Am 04.11.2013 um 10:48 hat Fam Zheng geschrieben: > >>On 11/04/2013 05:31 PM, Stefan Hajnoczi wrote: > >>>On Wed, Oct 30, 2013 at 02:49:32PM +0100, Markus Armbruster wrote: > The firs