Re: [Qemu-devel] NBD block device backend - 'improvements'

2011-02-16 Thread Kevin Wolf
Hi Nick, [ Please use "reply to all" so that the CC list is kept intact, re-adding Stefan ] Am 15.02.2011 22:26, schrieb Nicholas Thomas: > Hi Kevin, Stefan. > > On Tue, 2011-02-15 at 12:09 +0100, Kevin Wolf wrote: >> Am 14.02.2011 21:32, schrieb Stefan Hajnoczi: > [...] >>> block/nbd.c needs to

Re: [Qemu-devel] NBD block device backend - 'improvements'

2011-02-15 Thread Nicholas Thomas
Hi Kevin, Stefan. On Tue, 2011-02-15 at 12:09 +0100, Kevin Wolf wrote: > Am 14.02.2011 21:32, schrieb Stefan Hajnoczi: [...] > > block/nbd.c needs to be made asynchronous in order for this change to > > work. > > And even then it's not free of problem: For example qemu_aio_flush() > will hang.

Re: [Qemu-devel] NBD block device backend - 'improvements'

2011-02-15 Thread Kevin Wolf
Am 14.02.2011 21:32, schrieb Stefan Hajnoczi: > On Mon, Feb 14, 2011 at 7:40 PM, Nicholas Thomas wrote: >> I've written a patch that changes the behaviour - instead of exiting at >> startup, we wait for the NBD connection to be established, and we hang >> on reads and writes until the connection i

Re: [Qemu-devel] NBD block device backend - 'improvements'

2011-02-14 Thread Stefan Hajnoczi
On Mon, Feb 14, 2011 at 7:40 PM, Nicholas Thomas wrote: > I've written a patch that changes the behaviour - instead of exiting at > startup, we wait for the NBD connection to be established, and we hang > on reads and writes until the connection is re-established. Hi Nick, I think reconnect is a

[Qemu-devel] NBD block device backend - 'improvements'

2011-02-14 Thread Nicholas Thomas
[Apologies for the cross-post - I originally sent this to the KVM ML - obviously, it's far more appropriate here] Hi, I've been doing some work with /block/nbd.c with the aim of improving its behaviour when the NBD server is inaccessible or goes away. Current behaviour is to exit on startup if c