Re: [Qemu-devel] Possible reference leak in device_set_realized(...)

2016-01-12 Thread Paolo Bonzini
On 12/01/2016 11:44, Knut Omang wrote: > On Fri, 2016-01-01 at 23:37 +0100, Paolo Bonzini wrote: >> >> On 31/12/2015 19:13, Ilya Lesokhin wrote: >>> I was able to overcome this issue by calling object_unparent on my >>> device but I’m not sure that the correct way of fixing it. >> >> Yes, it's de

Re: [Qemu-devel] Possible reference leak in device_set_realized(...)

2016-01-12 Thread Knut Omang
On Fri, 2016-01-01 at 23:37 +0100, Paolo Bonzini wrote: > > On 31/12/2015 19:13, Ilya Lesokhin wrote: > > I was able to overcome this issue by calling object_unparent on my > > device but I’m not sure that the correct way of fixing it. > > Yes, it's definitely the right way to fix it. Sorry for

Re: [Qemu-devel] Possible reference leak in device_set_realized(...)

2016-01-01 Thread Paolo Bonzini
On 31/12/2015 19:13, Ilya Lesokhin wrote: > I was able to overcome this issue by calling object_unparent on my > device but I’m not sure that the correct way of fixing it. Yes, it's definitely the right way to fix it. Paolo

[Qemu-devel] Possible reference leak in device_set_realized(...)

2015-12-31 Thread Ilya Lesokhin
Hi, I’m working on SRIOV support for VFIO and I’m suffering from a reference leak. I’m using Knut Omang’s patches for SRIOV[1]. When the VF’s are enabled I call pci_create(…) and then object_property_set_bool(OBJECT(&dev->qdev), true, "realized", &local_err); and when the VF’s are disabled I call