Re: [Qemu-devel] RAMBlocks and memory_region_init_ram_nomigrate

2018-08-14 Thread Dr. David Alan Gilbert
* Frank Yang (l...@google.com) wrote: > Ah got it, thanks for the replies / info! > > We're using a modified QEMU 2.12, and I don't see the migratable-only loops > and field, so it either got missed in the rebase or was added after 2.12. It went in after 2.12; it's b895de50 (followed by some clea

Re: [Qemu-devel] RAMBlocks and memory_region_init_ram_nomigrate

2018-08-13 Thread Frank Yang via Qemu-devel
Ah got it, thanks for the replies / info! We're using a modified QEMU 2.12, and I don't see the migratable-only loops and field, so it either got missed in the rebase or was added after 2.12. Frank On Mon, Aug 13, 2018 at 9:45 AM Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat

Re: [Qemu-devel] RAMBlocks and memory_region_init_ram_nomigrate

2018-08-13 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 13/08/2018 18:16, Frank Yang wrote: > > Hi Paolo, > > > > I see that migration/ram.c saves RAMBlocks associated with memory > > regions initialized with nomigrate. Is this intended? > > Probably the name and size of the RAMBlocks must match but th

Re: [Qemu-devel] RAMBlocks and memory_region_init_ram_nomigrate

2018-08-13 Thread Peter Maydell
On 13 August 2018 at 17:27, Paolo Bonzini wrote: > On 13/08/2018 18:16, Frank Yang wrote: >> Hi Paolo, >> >> I see that migration/ram.c saves RAMBlocks associated with memory >> regions initialized with nomigrate. Is this intended? Which regions, and which version of QEMU? In general for current-

Re: [Qemu-devel] RAMBlocks and memory_region_init_ram_nomigrate

2018-08-13 Thread Paolo Bonzini
On 13/08/2018 18:16, Frank Yang wrote: > Hi Paolo, > > I see that migration/ram.c saves RAMBlocks associated with memory > regions initialized with nomigrate. Is this intended? Probably the name and size of the RAMBlocks must match but the contents need not (but honestly I haven't looked at the c