[Qemu-devel] RE: [PATCH] audio: split sample conversion and volumemixing

2011-01-12 Thread Schildbach, Wolfgang
Ah, I assumed that the volume would be stored in a 32 bit integer, and be represented as a signed Q31 fixed point. Sorry for the noise. - Wolfgang -Original Message- From: malc [mailto:av1...@comtv.ru] Sent: Wednesday, January 12, 2011 12:15 AM To: Michael Walle Cc: Schildbach, Wolfgang

[Qemu-devel] Re: [PATCH] audio: split sample conversion and volumemixing

2011-01-11 Thread malc
On Tue, 11 Jan 2011, Michael Walle wrote: > > Hi Wolfgang, > > > The fixed point path for scaling in mixeng_volume() seems to be under by > > a factor of two, IMHO. The right shift should be by 31, not 32. (Because > > the volume, which I assume is a signed 32 bit integer, can be 0.5 at > > most

RE: [Qemu-devel] Re: [PATCH] audio: split sample conversion and volumemixing

2011-01-10 Thread Schildbach, Wolfgang
-Original Message- From: qemu-devel-bounces+wschi=dolby@nongnu.org [mailto:qemu-devel-bounces+wschi=dolby@nongnu.org] On Behalf Of Jan Kiszka Sent: Monday, January 10, 2011 9:44 PM To: Michael Walle Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] Re: [PATCH] audio: split sample