Re: [Qemu-devel] RFC: cleanups in ELF loader

2007-10-05 Thread J. Mayer
On Thu, 2007-10-04 at 12:20 +0100, Thiemo Seufer wrote: J. Mayer wrote: [snip] The thing I see is different is that the n32 ABI redefines elf_greg_t and elf_caddr_t as 32 bits. Maybe I missed something but those types seem not to be used by the ELF loader (or maybe I should look in a more

Re: [Qemu-devel] RFC: cleanups in ELF loader

2007-10-04 Thread Thiemo Seufer
J. Mayer wrote: [snip] The thing I see is different is that the n32 ABI redefines elf_greg_t and elf_caddr_t as 32 bits. Maybe I missed something but those types seem not to be used by the ELF loader (or maybe I should look in a more recent kernel ;-) ). Then, I have seen no apparent issue

Re: [Qemu-devel] RFC: cleanups in ELF loader

2007-10-03 Thread J. Mayer
On Mon, 2007-10-01 at 04:35 +0100, Thiemo Seufer wrote: J. Mayer wrote: On Sun, 2007-09-30 at 17:09 +0200, J. Mayer wrote: On Sun, 2007-09-30 at 14:38 +0100, Thiemo Seufer wrote: J. Mayer wrote: Following what I've done in the syscalls emulation routines, it appeared to

Re: [Qemu-devel] RFC: cleanups in ELF loader

2007-09-30 Thread Thiemo Seufer
J. Mayer wrote: Following what I've done in the syscalls emulation routines, it appeared to me that there seems to be a lot of confusions between host and target long in the ELF loader. But the ELF fields are tied to the ELFCLASS of the supported ABI, not to the register width of the machine

Re: [Qemu-devel] RFC: cleanups in ELF loader

2007-09-30 Thread J. Mayer
On Sun, 2007-09-30 at 14:38 +0100, Thiemo Seufer wrote: J. Mayer wrote: Following what I've done in the syscalls emulation routines, it appeared to me that there seems to be a lot of confusions between host and target long in the ELF loader. But the ELF fields are tied to the ELFCLASS of

Re: [Qemu-devel] RFC: cleanups in ELF loader

2007-09-30 Thread J. Mayer
On Sun, 2007-09-30 at 17:09 +0200, J. Mayer wrote: On Sun, 2007-09-30 at 14:38 +0100, Thiemo Seufer wrote: J. Mayer wrote: Following what I've done in the syscalls emulation routines, it appeared to me that there seems to be a lot of confusions between host and target long in the ELF

Re: [Qemu-devel] RFC: cleanups in ELF loader

2007-09-29 Thread Edgar E. Iglesias
On Sun, Sep 30, 2007 at 03:39:15AM +0200, J. Mayer wrote: Following what I've done in the syscalls emulation routines, it appeared to me that there seems to be a lot of confusions between host and target long in the ELF loader. I tried to fix this. I also noticed that the image infos

[Qemu-devel] RFC: cleanups in ELF loader

2007-09-29 Thread J. Mayer
Following what I've done in the syscalls emulation routines, it appeared to me that there seems to be a lot of confusions between host and target long in the ELF loader. I tried to fix this. I also noticed that the image infos start_data field was not computed as the Linux kernel does. As the ARM

Re: [Qemu-devel] RFC: cleanups in ELF loader

2007-09-29 Thread J. Mayer
On Sun, 2007-09-30 at 04:15 +0200, Edgar E. Iglesias wrote: On Sun, Sep 30, 2007 at 03:39:15AM +0200, J. Mayer wrote: Following what I've done in the syscalls emulation routines, it appeared to me that there seems to be a lot of confusions between host and target long in the ELF loader. I