Re: [Qemu-devel] Re: [PATCH] Revert "PCI: Convert pci_device_hot_add() to QObject"

2010-05-04 Thread Daniel P. Berrange
On Mon, May 03, 2010 at 11:59:55AM -0500, Anthony Liguori wrote: > On 05/03/2010 04:29 AM, Markus Armbruster wrote: > >Why am I proposing to remove pci_add from QMP before its replacement is > >ready? I want it out sooner rather than later, because it isn't fully > >functional (errors and drive_ad

Re: [Qemu-devel] Re: [PATCH] Revert "PCI: Convert pci_device_hot_add() to QObject"

2010-05-04 Thread Markus Armbruster
Anthony Liguori writes: > On 05/03/2010 04:29 AM, Markus Armbruster wrote: [...] >> Why am I proposing to remove pci_add from QMP before its replacement is >> ready? I want it out sooner rather than later, because it isn't fully >> functional (errors and drive_add are missing), and we do not pla

Re: [Qemu-devel] Re: [PATCH] Revert "PCI: Convert pci_device_hot_add() to QObject"

2010-05-03 Thread Anthony Liguori
On 05/03/2010 04:29 AM, Markus Armbruster wrote: Luiz Capitulino writes: On Mon, 26 Apr 2010 19:44:19 +0200 Markus Armbruster wrote: We don't want pci_add in QMP. Use device_add instead. This reverts commit 7a344f7ac7bb651d0556a933ed8060d3a9e5d949. Conflicts: hw/pci-ho

[Qemu-devel] Re: [PATCH] Revert "PCI: Convert pci_device_hot_add() to QObject"

2010-05-03 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 26 Apr 2010 19:44:19 +0200 > Markus Armbruster wrote: > >> We don't want pci_add in QMP. Use device_add instead. >> >> This reverts commit 7a344f7ac7bb651d0556a933ed8060d3a9e5d949. >> >> Conflicts: >> >> hw/pci-hotplug.c >> sysemu.h >> >> Signed-o

[Qemu-devel] Re: [PATCH] Revert "PCI: Convert pci_device_hot_add() to QObject"

2010-04-26 Thread Luiz Capitulino
On Mon, 26 Apr 2010 19:44:19 +0200 Markus Armbruster wrote: > We don't want pci_add in QMP. Use device_add instead. > > This reverts commit 7a344f7ac7bb651d0556a933ed8060d3a9e5d949. > > Conflicts: > > hw/pci-hotplug.c > sysemu.h > > Signed-off-by: Markus Armbruster The patch l