[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-15 Thread Jan Kiszka
Alexander Graf wrote: On 14.05.2010, at 18:17, Jan Kiszka wrote: Alexander Graf wrote: Now that I can finally reproduce the bug with --enable-io-thread, I can verify that it does *not* fix the issue. I do not trust your tests. :p I just tried to reproduce with --enable-io-thread and the

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-15 Thread Alexander Graf
On 15.05.2010, at 10:36, Jan Kiszka wrote: Alexander Graf wrote: On 14.05.2010, at 18:17, Jan Kiszka wrote: Alexander Graf wrote: Now that I can finally reproduce the bug with --enable-io-thread, I can verify that it does *not* fix the issue. I do not trust your tests. :p I just tried

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-15 Thread Jan Kiszka
Alexander Graf wrote: On 15.05.2010, at 10:36, Jan Kiszka wrote: Alexander Graf wrote: On 14.05.2010, at 18:17, Jan Kiszka wrote: Alexander Graf wrote: Now that I can finally reproduce the bug with --enable-io-thread, I can verify that it does *not* fix the issue. I do not trust your

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-14 Thread Alexander Graf
On 12.05.2010, at 20:51, Jan Kiszka wrote: Alexander Graf wrote: Jan Kiszka wrote: Alexander Graf wrote: Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-14 Thread Jan Kiszka
Alexander Graf wrote: On 12.05.2010, at 20:51, Jan Kiszka wrote: Alexander Graf wrote: Jan Kiszka wrote: Alexander Graf wrote: Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-14 Thread Alexander Graf
On 14.05.2010, at 18:17, Jan Kiszka wrote: Alexander Graf wrote: On 12.05.2010, at 20:51, Jan Kiszka wrote: Alexander Graf wrote: Jan Kiszka wrote: Alexander Graf wrote: Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-12 Thread Jan Kiszka
Alexander Graf wrote: Jan Kiszka wrote: Alexander Graf wrote: Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive at the back-end. This caused problems to

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-11 Thread Alexander Graf
Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive at the back-end. This caused problems to front-end drivers whenever they were unable to read data immediately, e.g.

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-11 Thread Jan Kiszka
Alexander Graf wrote: Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive at the back-end. This caused problems to front-end drivers whenever they were unable to read

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-11 Thread Alexander Graf
Jan Kiszka wrote: Alexander Graf wrote: Jan Kiszka wrote: Move the buffer flush from mux_chr_read to mux_chr_can_read. While the latter is called periodically, the former will only be invoked when new characters arrive at the back-end. This caused problems to front-end drivers