[Qemu-devel] Re: [PATCH] device-assignment: Rework "name" of assigned pci device

2010-07-02 Thread Gerd Hoffmann
Hi, As far as I can tell, "name" predates the qdev conversion, and was used just for error messages and such. Yes, was already there when I touched the code the first time. It defaulted to "host". When Gerd did the qdev conversion, he made "id" default to "name", then "host". See commit 6

[Qemu-devel] Re: [PATCH] device-assignment: Rework "name" of assigned pci device

2010-07-02 Thread Markus Armbruster
[cc: kraxel] Hidetoshi Seto writes: > (2010/06/30 15:53), Markus Armbruster wrote: >> Summary: upstream qemu commit b560a9ab broke -pcidevice and pci_add host >> in two ways: >> >> * Use without options id and name is broken when option host contains >> ':'. That's because id defaults to hos

[Qemu-devel] Re: [PATCH] device-assignment: Rework "name" of assigned pci device

2010-06-30 Thread Hidetoshi Seto
(2010/06/30 15:53), Markus Armbruster wrote: > Summary: upstream qemu commit b560a9ab broke -pcidevice and pci_add host > in two ways: > > * Use without options id and name is broken when option host contains > ':'. That's because id defaults to host. I recommend to fix it > incompatibly: do

[Qemu-devel] Re: [PATCH] device-assignment: Rework "name" of assigned pci device

2010-06-29 Thread Markus Armbruster
Summary: upstream qemu commit b560a9ab broke -pcidevice and pci_add host in two ways: * Use without options id and name is broken when option host contains ':'. That's because id defaults to host. I recommend to fix it incompatibly: don't default id to host. The alternative is to get upst

[Qemu-devel] Re: [PATCH] device-assignment: Rework "name" of assigned pci device

2010-06-29 Thread Hidetoshi Seto
Thanks Markus, (2010/06/29 14:28), Markus Armbruster wrote: > Hidetoshi Seto writes: > >> "Hao, Xudong" writes: When assign one PCI device, qemu fail to parse the command line: qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0 Error: qemu-system-x86_64

[Qemu-devel] Re: [PATCH] device-assignment: Rework "name" of assigned pci device

2010-06-28 Thread Markus Armbruster
Hidetoshi Seto writes: > "Hao, Xudong" writes: >> > When assign one PCI device, qemu fail to parse the command line: >> > qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0 >> > Error: >> > qemu-system-x86_64: Parameter 'id' expects an identifier >> > Identifiers consist of