[Qemu-devel] Re: [PATCH] pass info about hpets to seabios.

2010-06-13 Thread Jan Kiszka
Gleb Natapov wrote: Currently HPET ACPI table is created regardless of whether qemu actually created hpet device. This may confuse some guests that don't check that hpet is functional before using it. Solve this by passing info about hpets in qemu to seabios via fw config interface. Additional

[Qemu-devel] Re: [PATCH] pass info about hpets to seabios.

2010-06-13 Thread Gleb Natapov
On Sun, Jun 13, 2010 at 06:56:37PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: Currently HPET ACPI table is created regardless of whether qemu actually created hpet device. This may confuse some guests that don't check that hpet is functional before using it. Solve this by passing info

[Qemu-devel] Re: [PATCH] pass info about hpets to seabios.

2010-06-13 Thread Jan Kiszka
Gleb Natapov wrote: On Sun, Jun 13, 2010 at 06:56:37PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: Currently HPET ACPI table is created regardless of whether qemu actually created hpet device. This may confuse some guests that don't check that hpet is functional before using it. Solve this

[Qemu-devel] Re: [PATCH] pass info about hpets to seabios.

2010-06-13 Thread Gleb Natapov
On Sun, Jun 13, 2010 at 07:41:14PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: On Sun, Jun 13, 2010 at 06:56:37PM +0200, Jan Kiszka wrote: Gleb Natapov wrote: Currently HPET ACPI table is created regardless of whether qemu actually created hpet device. This may confuse some guests that

Re: [Qemu-devel] Re: [PATCH] pass info about hpets to seabios.

2010-06-13 Thread Paul Brook
And I think we can move the capability setup into init. But this is not directly related to this patch, would just avoid adding this hunk to hpet_reset. I actually did that initially and tried to init hpet_cfg there too, but then noticed that mmio[0].addr below is not initialized at init

Re: [Qemu-devel] Re: [PATCH] pass info about hpets to seabios.

2010-06-13 Thread Gleb Natapov
On Sun, Jun 13, 2010 at 08:55:23PM +0100, Paul Brook wrote: And I think we can move the capability setup into init. But this is not directly related to this patch, would just avoid adding this hunk to hpet_reset. I actually did that initially and tried to init hpet_cfg there too, but