[Qemu-devel] Re: [PATCH] piix: use pci_config_set_prog_interface()

2010-12-29 Thread Sebastian Herbszt
Michael S. Tsirkin wrote: On Tue, Dec 28, 2010 at 07:48:23PM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Tue, Dec 28, 2010 at 05:24:06PM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Mon, Dec 20, 2010 at 10:18:01PM +0100, Sebastian Herbszt wrote: Use

[Qemu-devel] Re: [PATCH] piix: use pci_config_set_prog_interface()

2010-12-29 Thread Michael S. Tsirkin
On Wed, Dec 29, 2010 at 11:26:32AM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Tue, Dec 28, 2010 at 07:48:23PM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Tue, Dec 28, 2010 at 05:24:06PM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Mon, Dec

[Qemu-devel] Re: [PATCH] piix: use pci_config_set_prog_interface()

2010-12-29 Thread Michael S. Tsirkin
On Wed, Dec 29, 2010 at 11:26:32AM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Tue, Dec 28, 2010 at 07:48:23PM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Tue, Dec 28, 2010 at 05:24:06PM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Mon, Dec

[Qemu-devel] Re: [PATCH] piix: use pci_config_set_prog_interface()

2010-12-28 Thread Sebastian Herbszt
Michael S. Tsirkin wrote: On Mon, Dec 20, 2010 at 10:18:01PM +0100, Sebastian Herbszt wrote: Use pci_config_set_prog_interface(). Signed-off-by: Sebastian Herbszt herb...@gmx.de Since I was asked explicitly - I don't have a problem with these changes: both class and prog interface. However,

[Qemu-devel] Re: [PATCH] piix: use pci_config_set_prog_interface()

2010-12-28 Thread Michael S. Tsirkin
On Tue, Dec 28, 2010 at 05:24:06PM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Mon, Dec 20, 2010 at 10:18:01PM +0100, Sebastian Herbszt wrote: Use pci_config_set_prog_interface(). Signed-off-by: Sebastian Herbszt herb...@gmx.de Since I was asked explicitly - I don't have

[Qemu-devel] Re: [PATCH] piix: use pci_config_set_prog_interface()

2010-12-28 Thread Sebastian Herbszt
Michael S. Tsirkin wrote: On Tue, Dec 28, 2010 at 05:24:06PM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Mon, Dec 20, 2010 at 10:18:01PM +0100, Sebastian Herbszt wrote: Use pci_config_set_prog_interface(). Signed-off-by: Sebastian Herbszt herb...@gmx.de Since I was asked

[Qemu-devel] Re: [PATCH] piix: use pci_config_set_prog_interface()

2010-12-28 Thread Michael S. Tsirkin
On Tue, Dec 28, 2010 at 07:48:23PM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Tue, Dec 28, 2010 at 05:24:06PM +0100, Sebastian Herbszt wrote: Michael S. Tsirkin wrote: On Mon, Dec 20, 2010 at 10:18:01PM +0100, Sebastian Herbszt wrote: Use pci_config_set_prog_interface().

[Qemu-devel] Re: [PATCH] piix: use pci_config_set_prog_interface()

2010-12-27 Thread Michael S. Tsirkin
On Mon, Dec 20, 2010 at 10:18:01PM +0100, Sebastian Herbszt wrote: Use pci_config_set_prog_interface(). Signed-off-by: Sebastian Herbszt herb...@gmx.de Since I was asked explicitly - I don't have a problem with these changes: both class and prog interface. However, they aren't all that useful