[Qemu-devel] Re: [PATCH] vvfat mbr fixes

2007-09-24 Thread Lorenzo Campedelli
Johannes Schindelin wrote: Hi, On Mon, 24 Sep 2007, Ivan Kalvachev wrote: 2007/9/24, Johannes Schindelin [EMAIL PROTECTED]: On Mon, 24 Sep 2007, Ivan Kalvachev wrote: I had a discussion with Johannes Schindelin over my patch, that I thought is on the maillist, but apparently it wasn't.

[Qemu-devel] Re: [PATCH] vvfat mbr fixes

2007-09-24 Thread Johannes Schindelin
Hi, On Mon, 24 Sep 2007, Lorenzo Campedelli wrote: I think you were referring to the small patch I sent. I actually gave up with it, as I don't see how to make it in a clean way. Honestly I found your suggestion to try to have it less special-casing vvfat a bit puzzling... vvfat is the

[Qemu-devel] Re: [PATCH] vvfat mbr fixes

2007-09-23 Thread Lorenzo Campedelli
Johannes Schindelin wrote: Hi, On Sun, 23 Sep 2007, Ivan Kalvachev wrote: I've been having problems using vvfat virtual block device. Even linux fdisk was able to find problems with it. The reason turned out to be simple, MBR have bogus parameters. Thanks for doing this; I did not find any

Re: [Qemu-devel] Re: [PATCH] vvfat mbr fixes

2007-09-23 Thread Johannes Schindelin
Hi, On Sun, 23 Sep 2007, Lorenzo Campedelli wrote: While you are working on vvfat issues, could you give a look to the attached small patch? Okay, this is what I would do: - not make this handling dependent on vvfat (but this means checking if the colon is the second character, because

[Qemu-devel] Re: [PATCH] vvfat mbr fixes

2007-09-23 Thread Lorenzo Campedelli
Johannes Schindelin wrote: Hi, On Sun, 23 Sep 2007, Lorenzo Campedelli wrote: While you are working on vvfat issues, could you give a look to the attached small patch? Okay, this is what I would do: - not make this handling dependent on vvfat (but this means checking if the colon is the

[Qemu-devel] Re: [PATCH] vvfat mbr fixes

2007-09-23 Thread Johannes Schindelin
Hi, On Sun, 23 Sep 2007, Lorenzo Campedelli wrote: I was concerned by having this handling outside of a proper place (i.e. block-vvfat.c), but if we want to leave it there, wouldn't it be better to just handle cases which would otherwise fail, and just try to fix the fat: format? I don't

[Qemu-devel] Re: [PATCH] vvfat mbr fixes

2007-09-23 Thread Lorenzo Campedelli
Johannes Schindelin wrote: Hi, On Sun, 23 Sep 2007, Lorenzo Campedelli wrote: I was concerned by having this handling outside of a proper place (i.e. block-vvfat.c), but if we want to leave it there, wouldn't it be better to just handle cases which would otherwise fail, and just try to fix