On Thu, 8 Apr 2010 17:16:17 -0300 Miguel Di Ciurcio Filho <miguel.fi...@gmail.com> wrote:
> The VLANClientState structure has the member info_str, a simple string that > is filled with information about NIC devices and used on monitor calls. > > There is no coherent formatting of this string by all the NIC devices, > making it difficult to parse and represent this information over QMP. > > Patch 01 adds a new function qdict_to_qstring(). > > Patch 02 replaces the function qemu_nic_format_info_str by > qemu_nic_format_info_dict, adds a new QDict member to > VLANClientState named info_dict. > > Patches 03-21 updates all devices to feed information into the new QDict. > > Patch 22 converts the 'info network' monitor command to QObject, enabling QMP > support. This series has a number of small things to improve, but seems the right approach to me and in general looks very good. I'll followup individual patches. Two issues: 1. The following sequence triggers an assert() (qemu) netdev_add user,id=foo (qemu) info network The netdev_add command is available in my tree (see below). 2. The last patch conflicts with patches from Markus, you can rebase against my tree to solve that: git://repo.or.cz/qemu/qmp-unstable.git