[Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError

2010-03-25 Thread Daniel P. Berrange
On Wed, Mar 24, 2010 at 04:20:53PM -0300, Luiz Capitulino wrote: On Tue, 23 Mar 2010 11:27:54 +0100 Markus Armbruster arm...@redhat.com wrote: PATCH 3/4 changes syntax of set_link's second argument from up|down to on|off. I feel that the argument needs to be boolean in QMP, and this is

[Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError

2010-03-24 Thread Luiz Capitulino
On Tue, 23 Mar 2010 11:27:54 +0100 Markus Armbruster arm...@redhat.com wrote: PATCH 3/4 changes syntax of set_link's second argument from up|down to on|off. I feel that the argument needs to be boolean in QMP, and this is the simplest way to get it. Alternatives I could try if the syntax