[Qemu-devel] Re: [PATCH 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-08 Thread Paolo Bonzini
On 04/08/2011 09:15 AM, Amit Shah wrote: The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a mandatory command in the spec but we don't really implement it any of its sub-commands. The commit message for the last commit explains why implementing just the media subcommand is helpful an

[Qemu-devel] Re: [patch 0/5] block migration interaction fixes

2011-02-07 Thread Kevin Wolf
Am 26.01.2011 15:12, schrieb Marcelo Tosatti: > See individual patches for details. Thanks, applied all to the block branch. Kevin

[Qemu-devel] Re: [PATCH 0/5] -drive/drive_add fixes

2011-01-21 Thread Kevin Wolf
Am 17.01.2011 19:31, schrieb Markus Armbruster: > Note: PATCH 3/5 makes -drive reject duplicate definitions instead of > ignoring all but the first silently. If this isn't sufficiently > bug-compatible for you, we need to talk. > > Markus Armbruster (5): > blockdev: Fix error message for invali

[Qemu-devel] Re: [PATCH 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 14:00, Amit Shah wrote: Hi, This patchset adds new interfaces to work with iohandlers. It adds: int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque) -- Specify io handlers for an fd int remove_fd_handlers(int fd) -- Remove fd handlers for fd (mark ioh for deletio

[Qemu-devel] Re: [PATCH 0/5] Fix migration with NFS & iscsi/Fiber channel

2011-01-10 Thread Juan Quintela
Juan Quintela wrote: > Hi Nack myself :-( After discussions with hch on irc, he "convinced" me that only way to fix the problem is forcing O_DIRECT if migration is going to happen. So, changing patchset to check that cache=none is used in all read/write devices. Later, Juan. > This patch set

Re: [Qemu-devel] Re: [PATCH 0/5]

2010-11-25 Thread Stefan Hajnoczi
On Thu, Nov 25, 2010 at 2:30 AM, FUJITA Tomonori wrote: > On Wed, 24 Nov 2010 13:38:59 + > Stefan Hajnoczi wrote: > >> > This series adds rebased support for the hw/scsi-bsg.c backstore for >> > scsi-bus >> > compatible HBA emulation in QEMU-KVM on Linux hosts supporting the BSG >> > driver

Re: [Qemu-devel] Re: [PATCH 0/5]

2010-11-24 Thread FUJITA Tomonori
On Wed, 24 Nov 2010 13:38:59 + Stefan Hajnoczi wrote: > > This series adds rebased support for the hw/scsi-bsg.c backstore for > > scsi-bus > > compatible HBA emulation in QEMU-KVM on Linux hosts supporting the BSG > > driver > > against current mainline qemu-kvm.git/master code. > > I don

Re: [Qemu-devel] Re: [PATCH 0/5]

2010-11-24 Thread Christoph Hellwig
On Wed, Nov 24, 2010 at 01:38:59PM +, Stefan Hajnoczi wrote: > I don't know the Linux SCSI stack, so some basic questions for you :). > > With scsi-generic I can send SCSI commands to a device. How is bsg > different? The bsg code looks cleaner than sg but they both boil down > to issuing SC

[Qemu-devel] Re: [PATCH 0/5]

2010-11-24 Thread Stefan Hajnoczi
On Wed, Nov 24, 2010 at 8:39 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Greetings QEMU SCSI / BLOCK folks, > > This series adds rebased support for the hw/scsi-bsg.c backstore for scsi-bus > compatible HBA emulation in QEMU-KVM on Linux hosts supporting the BSG driver > again

[Qemu-devel] Re: [PATCH 0/5]: Add hw/scsi-bsg.c backend driver

2010-11-24 Thread Nicholas A. Bellinger
On Wed, 2010-11-24 at 11:31 +0200, Boaz Harrosh wrote: > On 11/24/2010 10:44 AM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > > > > > Greetings QEMU SCSI / BLOCK folks, > > > > This series adds rebased support for the hw/scsi-bsg.c backstore for > > scsi-bus > > compatibl

[Qemu-devel] Re: [PATCH 0/5]: Add hw/scsi-bsg.c backend driver

2010-11-24 Thread Boaz Harrosh
On 11/24/2010 10:44 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > > > Greetings QEMU SCSI / BLOCK folks, > > This series adds rebased support for the hw/scsi-bsg.c backstore for scsi-bus > compatible HBA emulation in QEMU-KVM on Linux hosts supporting the BSG driver > against

[Qemu-devel] Re: [PATCH 0/5]: Add hw/scsi-bsg.c backend driver

2010-11-24 Thread Kevin Wolf
Am 24.11.2010 09:44, schrieb Nicholas A. Bellinger: > From: Nicholas Bellinger > > Nicholas and Hannes, can both of you please make sure to use proper email threads for your patch series? On a list with some traffic, like qemu-devel, it's really hard to keep track otherwise because patches of a

[Qemu-devel] Re: [PATCH 0/5] virtio-net: More configurability and bh handling for tx

2010-09-01 Thread Michael S. Tsirkin
On Tue, Aug 31, 2010 at 04:26:07PM -0600, Alex Williamson wrote: > On Tue, 2010-08-31 at 16:33 -0500, Anthony Liguori wrote: > > On 08/31/2010 03:27 PM, Michael S. Tsirkin wrote: > > > On Fri, Aug 27, 2010 at 04:36:59PM -0600, Alex Williamson wrote: > > > > > >> Add the ability to configure the

[Qemu-devel] Re: [PATCH 0/5] virtio-net: More configurability and bh handling for tx

2010-08-31 Thread Alex Williamson
On Tue, 2010-08-31 at 16:33 -0500, Anthony Liguori wrote: > On 08/31/2010 03:27 PM, Michael S. Tsirkin wrote: > > On Fri, Aug 27, 2010 at 04:36:59PM -0600, Alex Williamson wrote: > > > >> Add the ability to configure the tx_timer timeout and add a bottom > >> half tx handler that typically show

[Qemu-devel] Re: [PATCH 0/5] virtio-net: More configurability and bh handling for tx

2010-08-31 Thread Anthony Liguori
On 08/31/2010 03:27 PM, Michael S. Tsirkin wrote: On Fri, Aug 27, 2010 at 04:36:59PM -0600, Alex Williamson wrote: Add the ability to configure the tx_timer timeout and add a bottom half tx handler that typically shows a nice perf boost over the time based approach. See last patch for perf

[Qemu-devel] Re: [PATCH 0/5] virtio-net: More configurability and bh handling for tx

2010-08-31 Thread Michael S. Tsirkin
On Fri, Aug 27, 2010 at 04:36:59PM -0600, Alex Williamson wrote: > Add the ability to configure the tx_timer timeout and add a bottom > half tx handler that typically shows a nice perf boost over the > time based approach. See last patch for perf details. Make this > the new default when the ioth

[Qemu-devel] Re: [PATCH 0/5] virtio-net: More configurability and bh handling for tx

2010-08-31 Thread Michael S. Tsirkin
On Fri, Aug 27, 2010 at 04:36:59PM -0600, Alex Williamson wrote: > Add the ability to configure the tx_timer timeout and add a bottom > half tx handler that typically shows a nice perf boost over the > time based approach. See last patch for perf details. Make this > the new default when the ioth

Re: [Qemu-devel] Re: [PATCH 0/5] RFC: distinguish warm reset from cold reset.

2010-08-30 Thread Gleb Natapov
On Mon, Aug 30, 2010 at 07:07:11PM +, Blue Swirl wrote: > On Mon, Aug 30, 2010 at 11:19 AM, Gleb Natapov wrote: > > On Mon, Aug 30, 2010 at 05:35:20PM +0900, Isaku Yamahata wrote: > >> On Mon, Aug 30, 2010 at 10:59:19AM +0300, Avi Kivity wrote: > >> >  On 08/30/2010 10:49 AM, Isaku Yamahata wr

Re: [Qemu-devel] Re: [PATCH 0/5] RFC: distinguish warm reset from cold reset.

2010-08-30 Thread Blue Swirl
On Mon, Aug 30, 2010 at 11:19 AM, Gleb Natapov wrote: > On Mon, Aug 30, 2010 at 05:35:20PM +0900, Isaku Yamahata wrote: >> On Mon, Aug 30, 2010 at 10:59:19AM +0300, Avi Kivity wrote: >> >  On 08/30/2010 10:49 AM, Isaku Yamahata wrote: >> >> This patch set distinguish warm reset from cold reset by

Re: [Qemu-devel] Re: [PATCH 0/5] RFC: distinguish warm reset from cold reset.

2010-08-30 Thread Gleb Natapov
On Mon, Aug 30, 2010 at 08:05:07AM -0500, Anthony Liguori wrote: > On 08/30/2010 06:19 AM, Gleb Natapov wrote: > >Why stop there. Why not implement proper power planes support. Some > >devices are not powered down on S3/S4 suspend for instance. > > What feature would it give us? The mapping of D-

Re: [Qemu-devel] Re: [PATCH 0/5] RFC: distinguish warm reset from cold reset.

2010-08-30 Thread Anthony Liguori
On 08/30/2010 06:19 AM, Gleb Natapov wrote: Why stop there. Why not implement proper power planes support. Some devices are not powered down on S3/S4 suspend for instance. What feature would it give us? The mapping of D-state to S-state is defined by the ACPI tables, no? So we're in tota

[Qemu-devel] Re: [PATCH 0/5] RFC: distinguish warm reset from cold reset.

2010-08-30 Thread Glauber Costa
On Mon, Aug 30, 2010 at 05:35:20PM +0900, Isaku Yamahata wrote: > On Mon, Aug 30, 2010 at 10:59:19AM +0300, Avi Kivity wrote: > > On 08/30/2010 10:49 AM, Isaku Yamahata wrote: > >> This patch set distinguish warm reset from cold reset by > >> introducing warm reset callback handler. > >> The first

Re: [Qemu-devel] Re: [PATCH 0/5] RFC: distinguish warm reset from cold reset.

2010-08-30 Thread Gleb Natapov
On Mon, Aug 30, 2010 at 05:35:20PM +0900, Isaku Yamahata wrote: > On Mon, Aug 30, 2010 at 10:59:19AM +0300, Avi Kivity wrote: > > On 08/30/2010 10:49 AM, Isaku Yamahata wrote: > >> This patch set distinguish warm reset from cold reset by > >> introducing warm reset callback handler. > >> The first

[Qemu-devel] Re: [PATCH 0/5] RFC: distinguish warm reset from cold reset.

2010-08-30 Thread Isaku Yamahata
On Mon, Aug 30, 2010 at 10:59:19AM +0300, Avi Kivity wrote: > On 08/30/2010 10:49 AM, Isaku Yamahata wrote: >> This patch set distinguish warm reset from cold reset by >> introducing warm reset callback handler. >> The first 4 patches are trivial clean up patches. The last patch of 5/5 >> is RFC p

[Qemu-devel] Re: [PATCH 0/5] RFC: distinguish warm reset from cold reset.

2010-08-30 Thread Avi Kivity
On 08/30/2010 10:49 AM, Isaku Yamahata wrote: This patch set distinguish warm reset from cold reset by introducing warm reset callback handler. The first 4 patches are trivial clean up patches. The last patch of 5/5 is RFC patch. The following thread arose cold reset vs warm reset issues. http:

[Qemu-devel] Re: [PATCH 0/5] CODING_STYLE amendments

2010-08-23 Thread Paolo Bonzini
On 08/22/2010 08:56 PM, Blue Swirl wrote: On Sun, Aug 22, 2010 at 6:41 PM, Anthony Liguori wrote: On 08/22/2010 11:49 AM, Jes Sorensen wrote: While wasting time for historical reasons is certainly better than wasting time for the heck of it, it's arguably worse than stopping the waste. But

[Qemu-devel] Re: [PATCH 0/5] CODING_STYLE amendments

2010-08-15 Thread Paolo Bonzini
On 08/12/2010 02:56 PM, malc wrote: On Thu, 12 Aug 2010, Blue Swirl wrote: Add a few rules, based loosely on libvirt HACKING. Blue Swirl (5): CODING_STYLE: add preprocessor rules CODING_STYLE: add C type rules CODING_STYLE: add memory management rules CODING_STYLE: add string manag

[Qemu-devel] Re: [PATCH 0/5] Migration subsections (and ide as example)

2010-06-15 Thread Juan Quintela
Anthony Liguori wrote: > On 06/15/2010 08:31 AM, Juan Quintela wrote: >> Hi >> >> At the end, here is the migration subsections implementation. As an example >> I ported the last >> two ide changes to migration to work with subsections. Notes: >> >> - subsections >>I went for qemu_peek_byte

[Qemu-devel] Re: [PATCH 0/5] scsi: More reset and hotplug fixes

2010-05-04 Thread Gerd Hoffmann
On 05/04/10 14:20, Jan Kiszka wrote: This series finally stabilizes system reset during ongoing SCSI I/O here. The first patch is a repost, the others include missing reset related bits that mostly concern the LSI controller. And the last patch addresses a disk hotplugging issue: The LSI used to

[Qemu-devel] Re: [PATCH 0/5] chardev, virtio-console: flow control, error handling

2010-04-06 Thread Amit Shah
On (Tue) Apr 06 2010 [10:17:12], Gerd Hoffmann wrote: >> So you mean just return -EAGAIN in case write returns with -EAGAIN? >> >> Yeah, makes sense. > > Yes. > > Note that for EINTR you want re-enter write() through so callers don't > have to worry about signals. Yes, of course.

[Qemu-devel] Re: [PATCH 0/5] chardev, virtio-console: flow control, error handling

2010-04-06 Thread Gerd Hoffmann
So you mean just return -EAGAIN in case write returns with -EAGAIN? Yeah, makes sense. Yes. Note that for EINTR you want re-enter write() through so callers don't have to worry about signals. cheers, Gerd

[Qemu-devel] Re: [PATCH 0/5] chardev, virtio-console: flow control, error handling

2010-04-06 Thread Amit Shah
On (Tue) Apr 06 2010 [09:36:17], Gerd Hoffmann wrote: > Hi, > >> In case of EAGAIN, the unix_write() function just kept spinning while >> attempting to write to the chardev till it succeeded. This resulted in >> a stuck VM in case a chardev had opened connection but wasn't reading >> anything fro

[Qemu-devel] Re: [PATCH 0/5] chardev, virtio-console: flow control, error handling

2010-04-06 Thread Gerd Hoffmann
Hi, In case of EAGAIN, the unix_write() function just kept spinning while attempting to write to the chardev till it succeeded. This resulted in a stuck VM in case a chardev had opened connection but wasn't reading anything from qemu. It spins only for non-blocking file handles. In blocking

Re: [Qemu-devel] Re: [PATCH 0/5] *** SUBJECT HERE ***

2010-04-01 Thread Paul Brook
> > One example is the openpic page size pointed out downthread. > > > > What about something like this (doesn't change all the places affected > > by your series, compile-tested only)? > > In general (with vmport and maybe virtio as the only exceptions), the > devices have no business knowing

Re: [Qemu-devel] Re: [PATCH 0/5] *** SUBJECT HERE ***

2010-03-31 Thread Aurelien Jarno
On Wed, Mar 31, 2010 at 08:08:52PM +0300, Blue Swirl wrote: > On 3/31/10, Paolo Bonzini wrote: > > On 03/26/2010 08:02 PM, Blue Swirl wrote: > > > Comments, anyone? > > > > Sorry I'm late. > > > > I don't really like the changes introduced here, because they make > > devices very very tied to

[Qemu-devel] Re: [PATCH 0/5] *** SUBJECT HERE ***

2010-03-31 Thread Blue Swirl
On 3/31/10, Paolo Bonzini wrote: > On 03/26/2010 08:02 PM, Blue Swirl wrote: > > Comments, anyone? > > Sorry I'm late. > > I don't really like the changes introduced here, because they make > devices very very tied to the boards. Hopefully this could be changed > one day with qdev, and patch

[Qemu-devel] Re: [PATCH 0/5] virtio: cleanup layout assumptions

2010-03-18 Thread Michael S. Tsirkin
On Thu, Mar 18, 2010 at 09:23:10AM +0100, Juan Quintela wrote: > Furthermore, your VIRTIO_COMMON_INIT() macro is ugly as hell, again to > gain us nothing. You are right here. Hang on, I'll fix it.

[Qemu-devel] Re: [PATCH 0/5] virtio: cleanup layout assumptions

2010-03-18 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > This patchset helps remove the assumption that vdev must be the 1st > member in any virtio device implementation. Other assumptions (made by > qdev) can be removed in a similar way separately, this patchset does not > do this yet. > Juan, this is an alternative to you

[Qemu-devel] Re: [PATCH 0/5] tcg-sparc improvements

2010-01-12 Thread Blue Swirl
On Mon, Jan 11, 2010 at 7:22 PM, Richard Henderson wrote: > As noticed elsewhere on the list mulu2_i32 is missing.  Which led > me to notice that add2_i32 and sub2_i32 were also missing and also > led me to notice that division was incorrectly implemented. > > My initial implementation of 32-bit d

[Qemu-devel] Re: [PATCH 0/5] tcg conditional set, round 4

2009-12-21 Thread Laurent Desnogues
On Mon, Dec 21, 2009 at 10:47 AM, Paolo Bonzini wrote: > On 12/21/2009 10:13 AM, Laurent Desnogues wrote: >> >> Which front-ends would need it and would the cost to generate >> code for it on some (most?) back-ends be amortized? > > The ARM front-end could definitely use a backend's ability to do

[Qemu-devel] Re: [PATCH 0/5] tcg conditional set, round 4

2009-12-21 Thread Paolo Bonzini
On 12/21/2009 10:13 AM, Laurent Desnogues wrote: Which front-ends would need it and would the cost to generate code for it on some (most?) back-ends be amortized? The ARM front-end could definitely use a backend's ability to do predication (via movcond). Paolo

[Qemu-devel] Re: [PATCH 0/5] Fix packet queueing to allow full tap queue drain

2009-10-28 Thread Mark McLoughlin
On Wed, 2009-10-28 at 11:36 +0800, Scott Tsai wrote: > > Scott, Sven, if you could test the tap-drain-queue branch from > > my tree, that would be great: > > http://repo.or.cz/w/qemu/markmc.git > > > > Thanks, > > Mark. > > Mark, > I've tested http://repo.or.cz/w/qemu/markmc.git and it

[Qemu-devel] Re: [PATCH 0/5] Fix packet queueing to allow full tap queue drain

2009-10-27 Thread Scott Tsai
> Scott, Sven, if you could test the tap-drain-queue branch from > my tree, that would be great: > http://repo.or.cz/w/qemu/markmc.git > > Thanks, > Mark. Mark, I've tested http://repo.or.cz/w/qemu/markmc.git and it indeed works for my test case (NFS through emulated smc91c111 NIC on