[Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Paolo Bonzini
On 06/08/2010 09:51 AM, Gerd Hoffmann wrote: On 06/08/10 01:51, Anthony Liguori wrote: Right now, if you set a QemuOpts option in a section twice, when you get the option you'll receive the value that was set the first time. This is less than ideal because if you're manipulating options in two

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Anthony Liguori
On 06/08/2010 05:32 AM, Paolo Bonzini wrote: On 06/08/2010 09:51 AM, Gerd Hoffmann wrote: On 06/08/10 01:51, Anthony Liguori wrote: Right now, if you set a QemuOpts option in a section twice, when you get the option you'll receive the value that was set the first time. This is less than ideal

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Gerd Hoffmann
On 06/08/10 15:07, Anthony Liguori wrote: Note that this reverses the ordering for users which want multiple values (slirp forwarding for example). And qemu_opt_find seems to have thought about this too: static QemuOpt *qemu_opt_find(QemuOpts *opts, const char *name) { QemuOpt *opt;

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Paul Brook
The problem I was trying to address can be seen with something like: -drive file=foo.img,if=virtio,file=bar.img You get no error, and foo.img is what gets used. It's fair to argue this is a silly use case but what I'm trying to achieve is to make it possible to do: -drive

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Anthony Liguori
On 06/08/2010 09:38 AM, Paul Brook wrote: The problem I was trying to address can be seen with something like: -drive file=foo.img,if=virtio,file=bar.img You get no error, and foo.img is what gets used. It's fair to argue this is a silly use case but what I'm trying to achieve is to make it

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Gerd Hoffmann
What'd expect is: [net user] guestfwd = fw1 fw2 fw3.. I think multiple entry options are probably not a good thing to have. We already have them though (-net switch so QemuOpts added them). cheers, Gerd

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Anthony Liguori
On 06/08/2010 08:44 AM, Gerd Hoffmann wrote: On 06/08/10 15:07, Anthony Liguori wrote: Note that this reverses the ordering for users which want multiple values (slirp forwarding for example). And qemu_opt_find seems to have thought about this too: static QemuOpt *qemu_opt_find(QemuOpts

Re: [Qemu-devel] Re: [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-08 Thread Anthony Liguori
On 06/08/2010 10:37 AM, Gerd Hoffmann wrote: What'd expect is: [net user] guestfwd = fw1 fw2 fw3.. I think multiple entry options are probably not a good thing to have. We already have them though (-net switch so QemuOpts added them). Yeah, but let's ignore that for the moment. If we