[Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev()

2010-06-29 Thread Markus Armbruster
Paolo Bonzini writes: > On 06/26/2010 04:46 PM, Markus Armbruster wrote: >> drive_get_by_blockdev()? blockdev_to_drive()? > > I like drive_find_by_blockdev or drive_get_by_blockdev, in any case > I'll make sure my own cpu_get_by_id is named in the same style that > you choose. drive_get_by_bloc

[Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev()

2010-06-28 Thread Paolo Bonzini
On 06/26/2010 04:46 PM, Markus Armbruster wrote: drive_get_by_blockdev()? blockdev_to_drive()? I like drive_find_by_blockdev or drive_get_by_blockdev, in any case I'll make sure my own cpu_get_by_id is named in the same style that you choose. Paolo

Re: [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev()

2010-06-27 Thread Christoph Hellwig
On Sat, Jun 26, 2010 at 04:46:28PM +0200, Markus Armbruster wrote: > drive_get_by_id() gets removed by 07/12. But there's still drive_get(). > > drive_get_by_blockdev()? blockdev_to_drive()? Oh well, just keep any name - it's not that important aftet all.

Re: [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev()

2010-06-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Sat, Jun 26, 2010 at 07:32:09AM +0200, Markus Armbruster wrote: >> Christoph Hellwig writes: >> >> >> +DriveInfo *drive_of_blockdev(BlockDriverState *bs) >> > >> > I'd call this find_drive_by_blockdev. >> >> For what it's worth, all externally visible functions d

[Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev()

2010-06-26 Thread Christoph Hellwig
On Sat, Jun 26, 2010 at 07:32:09AM +0200, Markus Armbruster wrote: > Christoph Hellwig writes: > > >> +DriveInfo *drive_of_blockdev(BlockDriverState *bs) > > > > I'd call this find_drive_by_blockdev. > > For what it's worth, all externally visible functions dealing with > drives start with "driv

[Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev()

2010-06-25 Thread Markus Armbruster
Christoph Hellwig writes: >> +DriveInfo *drive_of_blockdev(BlockDriverState *bs) > > I'd call this find_drive_by_blockdev. For what it's worth, all externally visible functions dealing with drives start with "drive_".

[Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev()

2010-06-25 Thread Christoph Hellwig
> +DriveInfo *drive_of_blockdev(BlockDriverState *bs) I'd call this find_drive_by_blockdev.