[Qemu-devel] Re: [PATCH 07/21] add assertions on the owner of a QemuMutex

2011-02-21 Thread Paolo Bonzini
On 02/21/2011 11:22 AM, Jan Kiszka wrote: That's easy, "p" will tell (the structure contains the owner's tid). And for debugging invalid mutex_unlock calls, it's more interesting to track the call path of that thread which incorrectly claimed to hold the lock. Ok, will remove. Paolo

[Qemu-devel] Re: [PATCH 07/21] add assertions on the owner of a QemuMutex

2011-02-21 Thread Jan Kiszka
On 2011-02-21 11:15, Paolo Bonzini wrote: > On 02/21/2011 10:50 AM, Jan Kiszka wrote: +/* An EDEADLOCK would arrive after we reset the owner. So this + assert is for ease of debugging (it lets you see what is the + actual owner. */ >> >> Don't get this. Why do yo

[Qemu-devel] Re: [PATCH 07/21] add assertions on the owner of a QemuMutex

2011-02-21 Thread Paolo Bonzini
On 02/21/2011 10:50 AM, Jan Kiszka wrote: > +/* An EDEADLOCK would arrive after we reset the owner. So this > + assert is for ease of debugging (it lets you see what is the > + actual owner. */ Don't get this. Why do you want to avoid the proper error detection of pthread?

[Qemu-devel] Re: [PATCH 07/21] add assertions on the owner of a QemuMutex

2011-02-21 Thread Jan Kiszka
On 2011-02-21 09:43, Paolo Bonzini wrote: > These are already present in the Win32 implementation, add them to > the pthread wrappers as well. > > Signed-off-by: Paolo Bonzini > --- > qemu-thread-posix.c | 27 +-- > qemu-thread-posix.h |1 + > 2 files changed, 26 in