Re: [Qemu-devel] Re: [PATCH 09/15] Parse SDR1 on mtspr instead of at translate time

2011-02-13 Thread David Gibson
On Sun, Feb 13, 2011 at 01:33:44PM +0100, Alexander Graf wrote: > > On 13.02.2011, at 10:02, David Gibson wrote: > > > On Sat, Feb 12, 2011 at 04:37:46PM +0100, Alexander Graf wrote: > >> On 12.02.2011, at 15:54, David Gibson wrote: > > [snip] > >>> +#define SDR_HTABORG_32 0xUL >

Re: [Qemu-devel] Re: [PATCH 09/15] Parse SDR1 on mtspr instead of at translate time

2011-02-13 Thread Alexander Graf
On 13.02.2011, at 10:02, David Gibson wrote: > On Sat, Feb 12, 2011 at 04:37:46PM +0100, Alexander Graf wrote: >> On 12.02.2011, at 15:54, David Gibson wrote: > [snip] >>> +#define SDR_HTABORG_32 0xUL >>> +#define SDR_HTABMASK 0x01FFUL >> >> Please mark this constan

Re: [Qemu-devel] Re: [PATCH 09/15] Parse SDR1 on mtspr instead of at translate time

2011-02-13 Thread David Gibson
On Sat, Feb 12, 2011 at 04:37:46PM +0100, Alexander Graf wrote: > On 12.02.2011, at 15:54, David Gibson wrote: [snip] > > +#define SDR_HTABORG_32 0xUL > > +#define SDR_HTABMASK 0x01FFUL > > Please mark this constant as ppc32 > > > + > > +#if defined(TARGET_PPC64) > >

[Qemu-devel] Re: [PATCH 09/15] Parse SDR1 on mtspr instead of at translate time

2011-02-12 Thread Alexander Graf
On 12.02.2011, at 15:54, David Gibson wrote: > On ppc machines with hash table MMUs, the special purpose register SDR1 > contains both the base address of the encoded size (hashed) page tables. > > At present, we interpret the SDR1 value within the address translation > path. But because the en