[Qemu-devel] Re: [PATCH 1/5] block: add discard support

2010-12-13 Thread Paolo Bonzini
On 12/10/2010 02:38 PM, Christoph Hellwig wrote: if it's smaller than the block size we'll zero out the remainder of the block. I think it should fail at VM startup time, or even better do nothing at all. When you write in the middle of an absent block, and a partially-zero block is created,

[Qemu-devel] Re: [PATCH 1/5] block: add discard support

2010-12-13 Thread Christoph Hellwig
On Mon, Dec 13, 2010 at 05:07:27PM +0100, Paolo Bonzini wrote: On 12/10/2010 02:38 PM, Christoph Hellwig wrote: if it's smaller than the block size we'll zero out the remainder of the block. I think it should fail at VM startup time, or even better do nothing at all. What should fail?

[Qemu-devel] Re: [PATCH 1/5] block: add discard support

2010-12-13 Thread Paolo Bonzini
On 12/13/2010 05:15 PM, Christoph Hellwig wrote: On Mon, Dec 13, 2010 at 05:07:27PM +0100, Paolo Bonzini wrote: On 12/10/2010 02:38 PM, Christoph Hellwig wrote: if it's smaller than the block size we'll zero out the remainder of the block. I think it should fail at VM startup time, or even