Re: [Qemu-devel] Re: [PATCH 12/15] Support 1T segments on ppc

2011-02-13 Thread David Gibson
On Sun, Feb 13, 2011 at 01:37:12PM +0100, Alexander Graf wrote: > On 13.02.2011, at 10:34, David Gibson wrote: > > On Sat, Feb 12, 2011 at 04:57:39PM +0100, Alexander Graf wrote: > >> On 12.02.2011, at 15:54, David Gibson wrote: > > [snip] > >>> +if (rb & (0x1000 - env->slb_nr)) > >> > >> Brac

Re: [Qemu-devel] Re: [PATCH 12/15] Support 1T segments on ppc

2011-02-13 Thread Alexander Graf
On 13.02.2011, at 10:34, David Gibson wrote: > On Sat, Feb 12, 2011 at 04:57:39PM +0100, Alexander Graf wrote: >> On 12.02.2011, at 15:54, David Gibson wrote: > [snip] >>> +if (rb & (0x1000 - env->slb_nr)) >> >> Braces... > > Oops, yeah. These later patches in the series I haven't really >

Re: [Qemu-devel] Re: [PATCH 12/15] Support 1T segments on ppc

2011-02-13 Thread David Gibson
On Sat, Feb 12, 2011 at 04:57:39PM +0100, Alexander Graf wrote: > On 12.02.2011, at 15:54, David Gibson wrote: [snip] > > +if (rb & (0x1000 - env->slb_nr)) > > Braces... Oops, yeah. These later patches in the series I haven't really audited for coding style adequately yet. I'll fix these be

[Qemu-devel] Re: [PATCH 12/15] Support 1T segments on ppc

2011-02-12 Thread Alexander Graf
On 12.02.2011, at 15:54, David Gibson wrote: > Traditionally, the "segments" used for the two-stage translation used on > powerpc MMUs were 256MB in size. This was the only option on all hash > page table based 32-bit powerpc cpus, and on the earlier 64-bit hash page > table based cpus. However