[Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-02-02 Thread Paolo Bonzini
On 02/01/2011 07:21 PM, Yoshiaki Tamura wrote: Paolo, I refactored the savevm functions. Could you give me your comments? I didn't review it thoroughly, but the abstractions seem okay. Paolo

[Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-02-02 Thread Yoshiaki Tamura
2011/2/2 Paolo Bonzini : > On 02/01/2011 07:21 PM, Yoshiaki Tamura wrote: >> >> Paolo, >> >> I refactored the savevm functions.  Could you give me your >> comments? > > I didn't review it thoroughly, but the abstractions seem okay. Thanks. Since It got a bit messy, I wanted hear your opinion. Yo

[Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-02-01 Thread Yoshiaki Tamura
Paolo, I refactored the savevm functions. Could you give me your comments? Thanks, Yoshi diff --git a/savevm.c b/savevm.c index 5418280..90aae55 100644 --- a/savevm.c +++ b/savevm.c @@ -1602,29 +1602,68 @@ bool qemu_savevm_state_blocked(Monitor *mon) return false; } -int qemu_savevm_sta

[Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-01-28 Thread Yoshiaki Tamura
2011/1/28 Paolo Bonzini : > On 01/28/2011 08:21 AM, Yoshiaki Tamura wrote: >> >> +int qemu_savevm_trans_begin(Monitor *mon, QEMUFile *f, int init) >> +{ >> +    SaveStateEntry *se; >> +    int skipped = 0; >> + >> +    QTAILQ_FOREACH(se,&savevm_handlers, entry) { >> +        int len, stage, ret; >>

[Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-01-28 Thread Paolo Bonzini
On 01/28/2011 08:21 AM, Yoshiaki Tamura wrote: +int qemu_savevm_trans_begin(Monitor *mon, QEMUFile *f, int init) +{ +SaveStateEntry *se; +int skipped = 0; + +QTAILQ_FOREACH(se,&savevm_handlers, entry) { +int len, stage, ret; + +if (se->save_live_state == NULL) { +