[Qemu-devel] Re: [PATCH 2/4] monitor: New argument type 'b'

2010-03-26 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Ok, but strncmp() will return 0 if p - beg = 0, right? In this case the current implementation will put true on the dict for a line like: (qemu) set_link foo Which should return an error to the user then. Brain fart. I'll respin. Thanks

[Qemu-devel] Re: [PATCH 2/4] monitor: New argument type 'b'

2010-03-25 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Tue, 23 Mar 2010 11:27:56 +0100 Markus Armbruster arm...@redhat.com wrote: This is a boolean value. Human monitor accepts on or off. Consistent with option parsing (see parse_option_bool()). Signed-off-by: Markus Armbruster

[Qemu-devel] Re: [PATCH 2/4] monitor: New argument type 'b'

2010-03-25 Thread Luiz Capitulino
On Thu, 25 Mar 2010 18:28:43 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Tue, 23 Mar 2010 11:27:56 +0100 Markus Armbruster arm...@redhat.com wrote: This is a boolean value. Human monitor accepts on or off. Consistent with option

[Qemu-devel] Re: [PATCH 2/4] monitor: New argument type 'b'

2010-03-24 Thread Luiz Capitulino
On Tue, 23 Mar 2010 11:27:56 +0100 Markus Armbruster arm...@redhat.com wrote: This is a boolean value. Human monitor accepts on or off. Consistent with option parsing (see parse_option_bool()). Signed-off-by: Markus Armbruster arm...@redhat.com --- monitor.c | 31