[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-12 Thread Gerd Hoffmann
Hi, Moving the handlers to a separate struct is clearly a incremental cleanup which can follow later. Using enable/disable flags will probably simplify the interfaces for the non-blocking mode and thus simplify the whole patch series so I think this should be done now. Agree -- but it looks

[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-11 Thread Amit Shah
On (Tue) Jan 11 2011 [16:54:48], Gerd Hoffmann wrote: > On 01/11/11 16:38, Amit Shah wrote: > >On (Tue) Jan 11 2011 [15:39:46], Gerd Hoffmann wrote: > >>On 01/11/11 12:10, Amit Shah wrote: > >>>Introduce a char-specific wrapper to qemu_set_fd_handler functions. > >>>This wrapper is useful to add /

[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-11 Thread Amit Shah
On (Tue) Jan 11 2011 [15:39:46], Gerd Hoffmann wrote: > On 01/11/11 12:10, Amit Shah wrote: > >Introduce a char-specific wrapper to qemu_set_fd_handler functions. > >This wrapper is useful to add / remove a write handler easily. Write > >handlers are only used when the backend is blocked and canno

[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-11 Thread Gerd Hoffmann
On 01/11/11 16:38, Amit Shah wrote: On (Tue) Jan 11 2011 [15:39:46], Gerd Hoffmann wrote: On 01/11/11 12:10, Amit Shah wrote: Introduce a char-specific wrapper to qemu_set_fd_handler functions. This wrapper is useful to add / remove a write handler easily. Write handlers are only used when the

[Qemu-devel] Re: [PATCH 2/5] char: Introduce char_set/remove_fd_handlers()

2011-01-11 Thread Gerd Hoffmann
On 01/11/11 12:10, Amit Shah wrote: Introduce a char-specific wrapper to qemu_set_fd_handler functions. This wrapper is useful to add / remove a write handler easily. Write handlers are only used when the backend is blocked and cannot receive any more input. I'd suggest to add flags to enable/