Izik Eidus wrote:
Index: qemu/cpu-all.h
===
--- qemu.orig/cpu-all.h 2008-02-01 15:24:45.0 -0600
+++ qemu/cpu-all.h 2008-02-01 15:28:48.0 -0600
@@ -695,7 +695,7 @@
/* page related stuff */
-#define
as far as i remember it was used to address something with
cpu_physical_memory_rw() probably related to TARGET_PAGE_SIZE
or ~TARGET_PAGE_SIZE,
the fact is that i dont know if it ever fixed anything
It fixes TARGET_PAGE_MASK, defined one line downscreen.
That doesn't really answer the
Paul Brook wrote:
as far as i remember it was used to address something with
cpu_physical_memory_rw() probably related to TARGET_PAGE_SIZE
or ~TARGET_PAGE_SIZE,
the fact is that i dont know if it ever fixed anything
It fixes TARGET_PAGE_MASK, defined one line downscreen.
That
On Sunday 10 February 2008, Avi Kivity wrote:
Paul Brook wrote:
as far as i remember it was used to address something with
cpu_physical_memory_rw() probably related to TARGET_PAGE_SIZE
or ~TARGET_PAGE_SIZE,
the fact is that i dont know if it ever fixed anything
It fixes
Paul Brook wrote:
On Sunday 10 February 2008, Avi Kivity wrote:
Paul Brook wrote:
as far as i remember it was used to address something with
cpu_physical_memory_rw() probably related to TARGET_PAGE_SIZE
or ~TARGET_PAGE_SIZE,
the fact is that i dont know if it ever fixed anything
On Sun, 2008-02-03 at 19:56 -0600, Anthony Liguori wrote:
Hi Izik,
Hi
Anthony Liguori wrote:
Index: qemu/cpu-all.h
===
--- qemu.orig/cpu-all.h 2008-02-01 15:24:45.0 -0600
+++ qemu/cpu-all.h 2008-02-01
Izik Eidus wrote:
Do you recall what this change fixed? As Paul pointed out in IRC, using
the host type here doesn't really fix the problem (target_ulong would be
more appropriate). However, we're both curious what problem it's
actually fixing since sign extending the int should just work.
Hi Izik,
Anthony Liguori wrote:
Index: qemu/cpu-all.h
===
--- qemu.orig/cpu-all.h 2008-02-01 15:24:45.0 -0600
+++ qemu/cpu-all.h 2008-02-01 15:28:48.0 -0600
@@ -695,7 +695,7 @@
/* page related stuff */