[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

2011-03-16 Thread Peter Maydell
On 16 March 2011 11:00, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This patch introduces a -display argument which consolidates the setting of the display mode. Valid options are: sdl/curses/default/serial (serial is equivalent to -nographic) You forgot to

[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

2011-03-16 Thread Jes Sorensen
On 03/16/11 12:46, Peter Maydell wrote: On 16 March 2011 11:00, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This patch introduces a -display argument which consolidates the setting of the display mode. Valid options are: sdl/curses/default/serial (serial is

[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

2011-03-15 Thread Peter Maydell
On 15 March 2011 12:36, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This patch introduces a -display argument which consolidates the setting of the display mode. Valid options are: sdl/curses/default/serial (serial is equivalent to -nographic) So I still think

[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

2011-03-15 Thread Anthony Liguori
On 03/15/2011 07:36 AM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com This patch introduces a -display argument which consolidates the setting of the display mode. Valid options are: sdl/curses/default/serial (serial is equivalent to -nographic) Signed-off-by: Jes

[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

2011-03-15 Thread Anthony Liguori
On 03/15/2011 09:07 AM, Peter Maydell wrote: On 15 March 2011 12:36,jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com This patch introduces a -display argument which consolidates the setting of the display mode. Valid options are: sdl/curses/default/serial (serial is

[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

2011-03-15 Thread Jes Sorensen
On 03/15/11 15:53, Anthony Liguori wrote: -nographic is effectively a convenience shortcut which changes the behaviour of several different devices (display, serial, parallel, at least). It doesn't belong under '-display' from an orthogonality argument, and people who want it because it is a

[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

2011-03-15 Thread Jes Sorensen
On 03/15/11 15:51, Anthony Liguori wrote: +} else if (strstart(opts, ,window_close=,nextopt)) { +opts = nextopt; +if (strstart(opts, on,nextopt)) { +no_quit = 0; +} else if (strstart(opts, off,nextopt)) { +

Re: [Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

2011-03-15 Thread Alexander Graf
On 15.03.2011, at 15:07, Peter Maydell wrote: On 15 March 2011 12:36, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This patch introduces a -display argument which consolidates the setting of the display mode. Valid options are: sdl/curses/default/serial