[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-08 Thread Luiz Capitulino
On Fri, 05 Mar 2010 17:43:40 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > > So, I won't nack it and the bigger mid-term discussion we should have > > is whether or not it's ok to mix qerror_report(), error_printf() & > > friends in handlers. > > I think mixing is both unavoid

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-05 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 4 Mar 2010 17:50:20 -0300 > Luiz Capitulino wrote: > >> On Thu, 4 Mar 2010 16:56:49 +0100 >> Markus Armbruster wrote: >> >> > While fully converted handlers are not supposed to print anything when >> > running in a QMP monitor, they are free to print in a hum

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-05 Thread Luiz Capitulino
On Thu, 4 Mar 2010 17:50:20 -0300 Luiz Capitulino wrote: > On Thu, 4 Mar 2010 16:56:49 +0100 > Markus Armbruster wrote: > > > While fully converted handlers are not supposed to print anything when > > running in a QMP monitor, they are free to print in a human monitor. > > I disagree. I've

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-04 Thread Luiz Capitulino
On Thu, 04 Mar 2010 22:06:42 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 4 Mar 2010 16:56:49 +0100 > > Markus Armbruster wrote: > > > >> While fully converted handlers are not supposed to print anything when > >> running in a QMP monitor, they are free to print in a

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-04 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 4 Mar 2010 16:56:49 +0100 > Markus Armbruster wrote: > >> While fully converted handlers are not supposed to print anything when >> running in a QMP monitor, they are free to print in a human monitor. > > I disagree. > > One of the key decisions behind the ne

[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor

2010-03-04 Thread Luiz Capitulino
On Thu, 4 Mar 2010 16:56:49 +0100 Markus Armbruster wrote: > While fully converted handlers are not supposed to print anything when > running in a QMP monitor, they are free to print in a human monitor. I disagree. One of the key decisions behind the new Monitor design is that handlers are p