[Qemu-devel] Re: [PATCH 3/3] piix_pci: optimize set irq path

2011-03-17 Thread Isaku Yamahata
On Thu, Mar 17, 2011 at 04:41:08PM +0200, Michael S. Tsirkin wrote: > > +static int piix3_post_load(void *opaque, int version_id) > > +{ > > +PIIX3State *piix3 = opaque; > > +piix3_rebuild_irq_levels(piix3); > > Don't we need to set_irq_pic here as well? > And in that case, just make the

[Qemu-devel] Re: [PATCH 3/3] piix_pci: optimize set irq path

2011-03-17 Thread Michael S. Tsirkin
On Thu, Mar 17, 2011 at 10:49:53PM +0900, Isaku Yamahata wrote: > optimize irq routing in piix_pic.c which has been a TODO. > > Cc: Michael S. Tsirkin > Signed-off-by: Isaku Yamahata Some minor comments, and looks like load has a minor bug - probably an old one as we didn't use to have a post l