Re: [Qemu-devel] Re: [PATCH 3/6] tcg-x86_64: Implement setcond and movcond.

2009-12-18 Thread Laurent Desnogues
On Fri, Dec 18, 2009 at 6:11 PM, Richard Henderson wrote: >> Also note that tcg_out_modrm will generate an unneeded prefix >> for some registers. cf. the patch I sent to the list months ago. > > Huh.  Didn't notice since the disassembler printed what I expected to see. >  Is fixing this at the sam

Re: [Qemu-devel] Re: [PATCH 3/6] tcg-x86_64: Implement setcond and movcond.

2009-12-18 Thread Richard Henderson
On 12/18/2009 03:39 AM, Laurent Desnogues wrote: +static void tcg_out_setcond(TCGContext *s, int cond, TCGArg arg0, +TCGArg arg1, TCGArg arg2, int const_arg2, int rexw) Perhaps renaming arg0 to dest would make things slightly more readable. Ok. Also note that tcg

[Qemu-devel] Re: [PATCH 3/6] tcg-x86_64: Implement setcond and movcond.

2009-12-18 Thread Laurent Desnogues
On Thu, Dec 17, 2009 at 6:32 PM, Richard Henderson wrote: > Implement conditional moves in the x86_64 backend. > > Signed-off-by: Richard Henderson > --- >  tcg/x86_64/tcg-target.c |   65 -- >  1 files changed, 62 insertions(+), 3 deletions(-) > > diff