On 07/03/2010 09:23 AM, Blue Swirl wrote:
On Fri, Jul 2, 2010 at 9:50 AM, Paolo Bonzini wrote:
The *global* env is still unavailable (i.e. no difference WRT poisoning), by
virtue of being defined in exec.h which is not available unless -DNEED_CPU_H
is defined.
So:
| before
On Fri, Jul 2, 2010 at 9:50 AM, Paolo Bonzini wrote:
> On 07/01/2010 09:42 PM, Blue Swirl wrote:
>>
>> I still maintain that 'env' may not be unpoisoned until the name is
>> less likely to invite accidents.
>
> The *global* env is still unavailable (i.e. no difference WRT poisoning), by
> virtue o
On 07/01/2010 09:42 PM, Blue Swirl wrote:
I still maintain that 'env' may not be unpoisoned until the name is
less likely to invite accidents.
The *global* env is still unavailable (i.e. no difference WRT
poisoning), by virtue of being defined in exec.h which is not available
unless -DNEED_CP
On Wed, Jun 30, 2010 at 8:56 AM, Paolo Bonzini wrote:
Wouldn't it be better to just put this in dyngen-exec.h ?
AFAICT there's a direct correlation between NEED_GLOBAL_ENV and #include
"exec.h".
>>>
>>> True, see cover letter in 0/4. I was told to make each file request
>>> explici
>>> Wouldn't it be better to just put this in dyngen-exec.h ?
>>> AFAICT there's a direct correlation between NEED_GLOBAL_ENV and #include
>>> "exec.h".
>>
>> True, see cover letter in 0/4. I was told to make each file request
>> explicitly the global variable though. So I'd have to leave the #if
> >> BTW, this may be useful for one thing: being able to include exec.h
> >> without bringing in the global variable.
> >
> > I'd argue that's not a desirable feature. I'd much rather have exec.h be
> > the controlling factor than have all files include the same set of
> > headers and have semant
On Tue, Jun 29, 2010 at 7:44 AM, Paolo Bonzini wrote:
> On 06/28/2010 10:29 PM, Paul Brook wrote:
>>>
>>> diff --git a/exec-all.h b/exec-all.h
>>> index a775582..ebe88ad 100644
>>> --- a/exec-all.h
>>> +++ b/exec-all.h
>>> @@ -353,4 +353,8 @@ extern int singlestep;
>>> /* cpu-exec.c */
>>> exter
On 06/29/2010 05:28 PM, Paul Brook wrote:
On 06/29/2010 03:51 PM, Paolo Bonzini wrote:
On 06/29/2010 01:30 PM, Paul Brook wrote:
I don't understand what this is supposed to achieve. The inclusion
of exec.h is what defines whether this global variable is
available. Just as importantly, it also p
> On 06/29/2010 03:51 PM, Paolo Bonzini wrote:
> > On 06/29/2010 01:30 PM, Paul Brook wrote:
> >> I don't understand what this is supposed to achieve. The inclusion
> >> of exec.h is what defines whether this global variable is
> >> available. Just as importantly, it also prevents code clobbering
>
On 06/29/2010 03:51 PM, Paolo Bonzini wrote:
On 06/29/2010 01:30 PM, Paul Brook wrote:
I don't understand what this is supposed to achieve. The inclusion
of exec.h is what defines whether this global variable is
available. Just as importantly, it also prevents code clobbering
this value. Having
On 06/29/2010 01:30 PM, Paul Brook wrote:
I don't understand what this is supposed to achieve.
The inclusion of exec.h is what defines whether this global variable is
available. Just as importantly, it also prevents code clobbering this value.
Having one without the other makes no sense.
Making
> On 06/28/2010 10:29 PM, Paul Brook wrote:
> >> diff --git a/exec-all.h b/exec-all.h
> >> index a775582..ebe88ad 100644
> >> --- a/exec-all.h
> >> +++ b/exec-all.h
> >> @@ -353,4 +353,8 @@ extern int singlestep;
> >>
> >> /* cpu-exec.c */
> >> extern volatile sig_atomic_t exit_request;
> >>
On 06/28/2010 10:29 PM, Paul Brook wrote:
diff --git a/exec-all.h b/exec-all.h
index a775582..ebe88ad 100644
--- a/exec-all.h
+++ b/exec-all.h
@@ -353,4 +353,8 @@ extern int singlestep;
/* cpu-exec.c */
extern volatile sig_atomic_t exit_request;
+#ifdef NEED_GLOBAL_ENV
+register CPUState *en
13 matches
Mail list logo
