[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-25 Thread Blue Swirl
On Mon, Oct 25, 2010 at 7:39 AM, Jes Sorensen wrote: > On 10/23/10 16:42, Blue Swirl wrote: >> On Mon, Oct 18, 2010 at 8:15 AM,   wrote: >>> From: Jes Sorensen >>> >>> Signed-off-by: Jes Sorensen >> >> Almost there: >>   CC    m68k-linux-user/m68k-semi.o >> /src/qemu/m68k-semi.c: In function 'do

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-25 Thread Jes Sorensen
On 10/23/10 16:42, Blue Swirl wrote: > On Mon, Oct 18, 2010 at 8:15 AM, wrote: >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen > > Almost there: > CCm68k-linux-user/m68k-semi.o > /src/qemu/m68k-semi.c: In function 'do_m68k_semihosting': > /src/qemu/m68k-semi.c:328: error: 'qemu_t

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-23 Thread Blue Swirl
On Mon, Oct 18, 2010 at 8:15 AM, wrote: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen Almost there: CCm68k-linux-user/m68k-semi.o /src/qemu/m68k-semi.c: In function 'do_m68k_semihosting': /src/qemu/m68k-semi.c:328: error: 'qemu_timeval' undeclared (first use in this function) /src

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-18 Thread Jes Sorensen
On 10/16/10 21:32, Blue Swirl wrote: > On Sat, Oct 16, 2010 at 4:04 PM, wrote: >> From: Jes Sorensen >> >> In addition add sysemu.h includes to file requiring a prototype for >> ffs() > > There are probably a lot more files which would need that: > /src/qemu/hw/sd.c: In function 'sd_normal_comm

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-16 Thread Blue Swirl
On Sat, Oct 16, 2010 at 4:04 PM, wrote: > From: Jes Sorensen > > In addition add sysemu.h includes to file requiring a prototype for > ffs() There are probably a lot more files which would need that: /src/qemu/hw/sd.c: In function 'sd_normal_command': /src/qemu/hw/sd.c:738:13: error: implicit d

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-16 Thread Jes Sorensen
On 10/15/10 18:39, Paolo Bonzini wrote: > On 10/15/2010 04:05 PM, jes.soren...@redhat.com wrote: >> +typedef struct timeval qemu_timeval; >> +#define qemu_gettimeofday(tp) gettimeofday(tp, NULL); > > Argh, trailing semicolon. Please remove it or use an inline function. Good point, it is present

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-15 Thread Paolo Bonzini
On 10/15/2010 04:05 PM, jes.soren...@redhat.com wrote: +typedef struct timeval qemu_timeval; +#define qemu_gettimeofday(tp) gettimeofday(tp, NULL); Argh, trailing semicolon. Please remove it or use an inline function. Paolo