[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-25 Thread Jes Sorensen
On 10/23/10 16:42, Blue Swirl wrote: On Mon, Oct 18, 2010 at 8:15 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Almost there: CCm68k-linux-user/m68k-semi.o /src/qemu/m68k-semi.c: In function

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-25 Thread Blue Swirl
On Mon, Oct 25, 2010 at 7:39 AM, Jes Sorensen jes.soren...@redhat.com wrote: On 10/23/10 16:42, Blue Swirl wrote: On Mon, Oct 18, 2010 at 8:15 AM,  jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Almost there:  

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-23 Thread Blue Swirl
On Mon, Oct 18, 2010 at 8:15 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com Almost there: CCm68k-linux-user/m68k-semi.o /src/qemu/m68k-semi.c: In function 'do_m68k_semihosting': /src/qemu/m68k-semi.c:328:

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-18 Thread Jes Sorensen
On 10/16/10 21:32, Blue Swirl wrote: On Sat, Oct 16, 2010 at 4:04 PM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com In addition add sysemu.h includes to file requiring a prototype for ffs() There are probably a lot more files which would need that:

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-16 Thread Jes Sorensen
On 10/15/10 18:39, Paolo Bonzini wrote: On 10/15/2010 04:05 PM, jes.soren...@redhat.com wrote: +typedef struct timeval qemu_timeval; +#define qemu_gettimeofday(tp) gettimeofday(tp, NULL); Argh, trailing semicolon. Please remove it or use an inline function. Good point, it is present in the

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-16 Thread Blue Swirl
On Sat, Oct 16, 2010 at 4:04 PM, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com In addition add sysemu.h includes to file requiring a prototype for ffs() There are probably a lot more files which would need that: /src/qemu/hw/sd.c: In function 'sd_normal_command':

[Qemu-devel] Re: [PATCH 5/9] Move qemu_gettimeofday() to OS specific files

2010-10-15 Thread Paolo Bonzini
On 10/15/2010 04:05 PM, jes.soren...@redhat.com wrote: +typedef struct timeval qemu_timeval; +#define qemu_gettimeofday(tp) gettimeofday(tp, NULL); Argh, trailing semicolon. Please remove it or use an inline function. Paolo