[Qemu-devel] Re: [PATCH RFC] msi: remove range checks

2010-10-25 Thread Isaku Yamahata
Seems good. For consistency, the range check in msix_write_config() should be also removed. On Mon, Oct 25, 2010 at 08:07:25AM +0200, Michael S. Tsirkin wrote: > config write handlers should be idempotent. > So no need for range checks. > > Signed-off-by: Michael S. Tsirkin > --- > hw/msi.c |

[Qemu-devel] Re: [PATCH RFC] msi: remove range checks

2010-10-25 Thread Michael S. Tsirkin
Hmm, does this simply check that write is within the capability? Then I think I misunderstood what this does. Please replace hard-coded length logic with existing function call that gets the lengths, the range check can stay then. On Mon, Oct 25, 2010 at 04:07:13PM +0900, Isaku Yamahata wrote: >