On Thu, 17 Jun 2010 09:58:37 -0300 Miguel Di Ciurcio Filho <miguel.fi...@gmail.com> wrote:
> The 'info snapshots' monitor command does not show snapshot information from > all > available block devices. > > Usage example: > $ qemu -hda disk1.qcow2 -hdb disk2.qcow2 > > (qemu) info snapshots > Snapshot devices: ide0-hd0 > Snapshot list (from ide0-hd0): > ID TAG VM SIZE DATE VM CLOCK > 1 1.5M 2010-05-26 21:51:02 00:00:03.263 > 2 1.5M 2010-05-26 21:51:09 00:00:08.844 > 3 1.5M 2010-05-26 21:51:24 00:00:23.274 > 4 1.5M 2010-05-26 21:53:17 00:00:03.595 > > In the above case, disk2.qcow2 has snapshot information, but it is not being > shown. Only the first device is always shown. > > This patch updates the do_info_snapshots() function do correctly show snapshot > information about all available block devices. > > New output: > (qemu) info snapshots > Snapshot list from ide0-hd0 (VM state image): > ID TAG VM SIZE DATE VM CLOCK > 1 1.5M 2010-05-26 21:51:02 00:00:03.263 > 2 1.5M 2010-05-26 21:51:09 00:00:08.844 > 3 1.5M 2010-05-26 21:51:24 00:00:23.274 > 4 1.5M 2010-05-26 21:53:17 00:00:03.595 > > Snapshot list from ide0-hd1: > ID TAG VM SIZE DATE VM CLOCK > 1 0 2010-05-26 21:51:02 00:00:03.263 > 2 0 2010-05-26 21:51:09 00:00:08.844 > 3 0 2010-05-26 21:51:24 00:00:23.274 > 4 0 2010-05-26 21:53:17 00:00:03.595 I agree we need this info somewhere, but I'm wondering if this output won't get users confused. Perhaps it would be perfect to have 'info snapshots -a', but the user Monitor don't support passing options to info commands. Suggestions?