[Qemu-devel] Re: [PATCH v3 06/13] pcie/aer: helper functions for pcie aer capability.

2010-09-27 Thread Michael S. Tsirkin
On Mon, Sep 27, 2010 at 03:03:24PM +0900, Isaku Yamahata wrote: > On Sun, Sep 26, 2010 at 02:46:51PM +0200, Michael S. Tsirkin wrote: > > > > > +static inline void pcie_aer_errmsg(PCIDevice *dev, const > > > > > PCIE_AERErrMsg *msg) > > > > > +{ > > > > > +assert(pci_is_express(dev)); > > > >

[Qemu-devel] Re: [PATCH v3 06/13] pcie/aer: helper functions for pcie aer capability.

2010-09-26 Thread Isaku Yamahata
On Sun, Sep 26, 2010 at 02:46:51PM +0200, Michael S. Tsirkin wrote: > > > > +static inline void pcie_aer_errmsg(PCIDevice *dev, const > > > > PCIE_AERErrMsg *msg) > > > > +{ > > > > +assert(pci_is_express(dev)); > > > > +assert(dev->exp.aer_errmsg); > > > > +dev->exp.aer_errmsg(dev, ms

[Qemu-devel] Re: [PATCH v3 06/13] pcie/aer: helper functions for pcie aer capability.

2010-09-26 Thread Michael S. Tsirkin
On Fri, Sep 24, 2010 at 11:50:21AM +0900, Isaku Yamahata wrote: > On Wed, Sep 22, 2010 at 01:50:16PM +0200, Michael S. Tsirkin wrote: > > > > +} > > > + > > > +/* capability & control */ > > > +if (ranges_overlap(addr, len, pos + PCI_ERR_CAP, 4)) { > > > +uint32_t err_cap = pci

[Qemu-devel] Re: [PATCH v3 06/13] pcie/aer: helper functions for pcie aer capability.

2010-09-23 Thread Isaku Yamahata
On Wed, Sep 22, 2010 at 01:50:16PM +0200, Michael S. Tsirkin wrote: > > +} > > + > > +/* capability & control */ > > +if (ranges_overlap(addr, len, pos + PCI_ERR_CAP, 4)) { > > +uint32_t err_cap = pci_get_long(dev->config + pos + PCI_ERR_CAP); > > +if (!(err_cap & PCI_E

[Qemu-devel] Re: [PATCH v3 06/13] pcie/aer: helper functions for pcie aer capability.

2010-09-22 Thread Michael S. Tsirkin
On Wed, Sep 15, 2010 at 02:38:19PM +0900, Isaku Yamahata wrote: > This patch implements helper functions for pcie aer capability > which will be used later. > > Signed-off-by: Isaku Yamahata > --- > Changes v2 -> v3: > - split out from pcie.[ch] to pcie_aer.[ch] to make the files sorter. > - embe