Re: [Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-10 Thread 乔崇
Alexander Graf 写道: Hi Chong, 乔崇 wrote: Alexander Graf 写道: Hi Chong (or Qiao? Which one is your first name?), Thanks your advice,My first name is Chong. Upfront - please don't top post. Top posting is when you write your reply

[Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-09 Thread Alexander Graf
Hi Chong, 乔崇 wrote: Alexander Graf 写道: Hi Chong (or Qiao? Which one is your first name?), Thanks your advice,My first name is Chong. Upfront - please don't top post. Top posting is when you write your reply at the top of the mail. This is considered bad style on most open source

Re: [Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-05 Thread Sebastian Herbszt
乔崇 wrote: I add Sebastian Herbsz's patch,add WIN_WIN_STANDBYNOW1 support to fix hw_error on linux shut down etc. I am not familiar with git send-email,I am studying it now :). [snip] From e94912b03ed33080d550eb5764fc99911498101b Mon Sep 17 00:00:00 2001 From: QiaoChong

[Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-05 Thread Sebastian Herbszt
Elek Roland wrote: On v, 2010-05-02 at 17:56 +0200, Elek Roland wrote: I'm going to try the patch in practice as soon as I finish my university project. (It's due today.) I've tried the patch, and I can confirm that it does provide an AHCI device and a SATA disk. It shows up in qemu as an

Re: [Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-05 Thread Stuart Brady
On Tue, May 04, 2010 at 10:51:37PM +0200, Sebastian Herbszt wrote: diff --git a/hw/pci_ids.h b/hw/pci_ids.h index fe7a121..4d4de93 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -97,3 +97,4 @@ #define PCI_DEVICE_ID_INTEL_82371AB 0x7111 #define PCI_DEVICE_ID_INTEL_82371AB_20x7112

[Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-03 Thread Elek Roland
On v, 2010-05-02 at 17:56 +0200, Elek Roland wrote: I'm going to try the patch in practice as soon as I finish my university project. (It's due today.) I've tried the patch, and I can confirm that it does provide an AHCI device and a SATA disk. It shows up in qemu as an Intel Corporation

[Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-03 Thread Alexander Graf
Hi Chong (or Qiao? Which one is your first name?), Upfront - please don't top post. Top posting is when you write your reply at the top of the mail. This is considered bad style on most open source mailing lists. Instead, people here usually send inline comments. So they put their reply below

Re: [Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-03 Thread 乔崇
I add Sebastian Herbsz's patch,add WIN_WIN_STANDBYNOW1 support to fix hw_error on linux shut down etc. I am not familiar with git send-email,I am studying it now :). Sebastian Herbszt 写道: Hi again, please consider the following minor changes: - debug output with DEBUG_AHCI - set port

[Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-02 Thread Sebastian Herbszt
Hi, 乔崇 wrote: Hi,Alexander Graf. I am very glad you noticed my patch about ahci.I love qemu just like I love linux.I wish I could do much more work on qemu development. I had cloned qemu from master branch,add my patch into it,and tested ahci on i386 softmmu. If anyone is interested on

Re: [Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-02 Thread Avi Kivity
On 05/02/2010 06:36 PM, Sebastian Herbszt wrote: ./configure --target-list=i386-softmmu make dd if=/dev/zero of=/tmp/disk bs=1M count=100 ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -boot d -drive if=sd,file=/tmp/disk After linux boot,you will find a ahci device named

[Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-02 Thread Elek Roland
Hi all, I am the GSoC student working on the project. I haven't tried the patch yet, but I've read the code. It could use general cleanup and a lot of development indeed, but otherwise it looks like a good base to build complete support on so far. I'm going to try the patch in practice as soon as

[Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-02 Thread Sebastian Herbszt
Hi again, please consider the following minor changes: - debug output with DEBUG_AHCI - set port count to 4 - change return value of PxSSTS to include SPD and IPM - change cap and version default values according to Intel #301473-002 Regards, Sebastian --- hw/ahci.c.orig Sun May 2 15:43:58