[Qemu-devel] Re: [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-09 Thread Avi Kivity
On 06/09/2010 12:41 AM, Chris Wright wrote: pci. D.F. (B:D.F?) D:B:D.F bar rom bar.n -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] Re: [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-09 Thread Paul Brook
* Alex Williamson (alex.william...@redhat.com) wrote: +// XXX check duplicates Yes, definitely. You created a notion of a hierarchical namespace, can this be formalized any more? We already have one: The qdev tree. Paul

[Qemu-devel] Re: [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Anthony Liguori
On 06/08/2010 02:15 PM, Alex Williamson wrote: The offset given to a block created via qemu_ram_alloc/map() is arbitrary, let the caller specify a name so we can make a positive match. Note, this only addresses the qemu-kvm callers so far. Signed-off-by: Alex

[Qemu-devel] Re: [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Alex Williamson
On Tue, 2010-06-08 at 15:07 -0500, Anthony Liguori wrote: On 06/08/2010 02:15 PM, Alex Williamson wrote: The offset given to a block created via qemu_ram_alloc/map() is arbitrary, let the caller specify a name so we can make a positive match. Note, this only addresses the qemu-kvm callers

[Qemu-devel] Re: [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Chris Wright
* Alex Williamson (alex.william...@redhat.com) wrote: +// XXX check duplicates Yes, definitely. You created a notion of a hierarchical namespace, can this be formalized any more? Currently scattered... +char name[14]; +snprintf(name, sizeof(name),

[Qemu-devel] Re: [RFC PATCH 3/6] RAMBlock: Add a name field

2010-06-08 Thread Alex Williamson
On Tue, 2010-06-08 at 14:41 -0700, Chris Wright wrote: * Alex Williamson (alex.william...@redhat.com) wrote: +// XXX check duplicates Yes, definitely. Yep, I was just thinking that without freeing, the uniqueness really falls apart. If we hotplug a nic multiple times on the source,