Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-08 Thread Luiz Capitulino
On Fri, 08 Jan 2010 11:01:31 -0600 Adam Litke wrote: > On Thu, 2010-01-07 at 16:30 -0200, Luiz Capitulino wrote: > > On Thu, 7 Jan 2010 15:58:30 -0200 > > Luiz Capitulino wrote: > > > > > I like Daniel's idea too. In practice 'refresh-balloon' is going to > > > be Anthony's idea #1 for the QMP

Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-08 Thread Adam Litke
On Thu, 2010-01-07 at 16:30 -0200, Luiz Capitulino wrote: > On Thu, 7 Jan 2010 15:58:30 -0200 > Luiz Capitulino wrote: > > > I like Daniel's idea too. In practice 'refresh-balloon' is going to > > be Anthony's idea #1 for the QMP case, which seems the right way to > > do it with QMP. > > Hm, s

Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-08 Thread Luiz Capitulino
On Fri, 08 Jan 2010 10:31:28 -0600 Anthony Liguori wrote: > On 01/07/2010 12:30 PM, Luiz Capitulino wrote: > > On Thu, 7 Jan 2010 15:58:30 -0200 > > Luiz Capitulino wrote: > > > > > >> I like Daniel's idea too. In practice 'refresh-balloon' is going to > >> be Anthony's idea #1 for the QMP

Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-08 Thread Anthony Liguori
On 01/07/2010 12:30 PM, Luiz Capitulino wrote: On Thu, 7 Jan 2010 15:58:30 -0200 Luiz Capitulino wrote: I like Daniel's idea too. In practice 'refresh-balloon' is going to be Anthony's idea #1 for the QMP case, which seems the right way to do it with QMP. Hm, something that has

Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-07 Thread Jamie Lokier
Anthony Liguori wrote: > On 01/07/2010 09:18 AM, Avi Kivity wrote: > >On 01/07/2010 05:12 PM, Anthony Liguori wrote: > >> > >>3) Make qemu request balloon stats regularly (maybe every 10 seconds) > >>and display the latest stats with info balloon. This avoids the > >>problem in #2 but it means t

Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-07 Thread Luiz Capitulino
On Thu, 7 Jan 2010 15:58:30 -0200 Luiz Capitulino wrote: > I like Daniel's idea too. In practice 'refresh-balloon' is going to > be Anthony's idea #1 for the QMP case, which seems the right way to > do it with QMP. Hm, something that has just occurred to me: it's easy to have async messages in

Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-07 Thread Luiz Capitulino
On Thu, 07 Jan 2010 10:56:19 -0600 Anthony Liguori wrote: > On 01/07/2010 10:39 AM, Avi Kivity wrote: > > On 01/07/2010 06:27 PM, Adam Litke wrote: > >> > >>> I think 'info-balloon' should be synchronous and without side-effects. > >>> ie return the current stats that QEMU has. We could then add

Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-07 Thread Anthony Liguori
On 01/07/2010 10:39 AM, Avi Kivity wrote: On 01/07/2010 06:27 PM, Adam Litke wrote: I think 'info-balloon' should be synchronous and without side-effects. ie return the current stats that QEMU has. We could then add a separate 'refresh-balloon' command + async event notification when that com

Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-07 Thread Daniel P. Berrange
On Thu, Jan 07, 2010 at 09:12:10AM -0600, Anthony Liguori wrote: > On 01/05/2010 11:08 AM, Adam Litke wrote: > >This patch has been discussed (and ACKed) in the past, but has not yet > >been committed due to the congestion surrounding the 0.12 release and > >other conflicting changes. I would like

Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-07 Thread Avi Kivity
On 01/07/2010 06:27 PM, Adam Litke wrote: I think 'info-balloon' should be synchronous and without side-effects. ie return the current stats that QEMU has. We could then add a separate 'refresh-balloon' command + async event notification when that completes. The tool that is requiring the stats

Re: [Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-07 Thread Adam Litke
On Thu, 2010-01-07 at 15:49 +, Daniel P. Berrange wrote: > On Thu, Jan 07, 2010 at 09:12:10AM -0600, Anthony Liguori wrote: > > On 01/05/2010 11:08 AM, Adam Litke wrote: > > >This patch has been discussed (and ACKed) in the past, but has not yet > > >been committed due to the congestion surroun

[Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-07 Thread Adam Litke
Thanks for the ideas and feedback. I will play around with #4 and see if I can hack up a prototype. On Thu, 2010-01-07 at 09:22 -0600, Anthony Liguori wrote: > On 01/07/2010 09:18 AM, Avi Kivity wrote: > > On 01/07/2010 05:12 PM, Anthony Liguori wrote: > >> > >> 3) Make qemu request balloon stats

[Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-07 Thread Anthony Liguori
On 01/07/2010 09:18 AM, Avi Kivity wrote: On 01/07/2010 05:12 PM, Anthony Liguori wrote: 3) Make qemu request balloon stats regularly (maybe every 10 seconds) and display the latest stats with info balloon. This avoids the problem in #2 but it means that qemu determines the poll rate instead

[Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-07 Thread Avi Kivity
On 01/07/2010 05:12 PM, Anthony Liguori wrote: 3) Make qemu request balloon stats regularly (maybe every 10 seconds) and display the latest stats with info balloon. This avoids the problem in #2 but it means that qemu determines the poll rate instead of a management tool. 4) Make info-ball

[Qemu-devel] Re: [RFD] virtio: Add memory statistics reporting to the balloon driver

2010-01-07 Thread Anthony Liguori
On 01/05/2010 11:08 AM, Adam Litke wrote: This patch has been discussed (and ACKed) in the past, but has not yet been committed due to the congestion surrounding the 0.12 release and other conflicting changes. I would like to rekindle the discussion so that I can make the necessary changes to ge