[Qemu-devel] Re: [SeaBIOS] [PATCH 2/2] seabios: pciinit: fix overflow when bar allocation.

2010-07-27 Thread Isaku Yamahata
On Mon, Jul 26, 2010 at 09:45:42PM -0400, Kevin O'Connor wrote: > On Mon, Jul 26, 2010 at 02:02:46PM +0900, Isaku Yamahata wrote: > > When allocating bar, overflow can occur. > > So add overflow check and don't allocate bar if overflowed. > > Overflow check is ugly, but necessary. > > Another sugge

[Qemu-devel] Re: [SeaBIOS] [PATCH 2/2] seabios: pciinit: fix overflow when bar allocation.

2010-07-26 Thread Kevin O'Connor
On Mon, Jul 26, 2010 at 02:02:46PM +0900, Isaku Yamahata wrote: > When allocating bar, overflow can occur. > So add overflow check and don't allocate bar if overflowed. > Overflow check is ugly, but necessary. > Another suggested way is to change related variables u64 from u32 > thus overflow can't