Re: [Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines

2007-12-07 Thread Anthony Liguori
Ryan Harper wrote: * Anthony Liguori [EMAIL PROTECTED] [2007-12-07 15:07]: Ryan Harper wrote: * Anthony Liguori [EMAIL PROTECTED] [2007-12-07 14:49]: + +CPUState *first_cpu; This should probably be static. doh, should be extern actually since

[Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines

2007-12-07 Thread Anthony Liguori
Ryan Harper wrote: 5 files changed, 754 insertions(+), 2 deletions(-) Makefile.target |4 hw/pc.c | 47 smbios.c| 519 +++ smbios_types.h | 182 +++ sysemu.h|4 # HG changeset patch #

Re: [Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines

2007-12-07 Thread Ryan Harper
* Anthony Liguori [EMAIL PROTECTED] [2007-12-07 15:07]: Ryan Harper wrote: * Anthony Liguori [EMAIL PROTECTED] [2007-12-07 14:49]: + +CPUState *first_cpu; This should probably be static. doh, should be extern actually since it's defined elsewhere. Perhaps you

[Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines

2007-12-07 Thread Ryan Harper
* Anthony Liguori [EMAIL PROTECTED] [2007-12-07 14:49]: Ryan Harper wrote: 5 files changed, 754 insertions(+), 2 deletions(-) Makefile.target |4 hw/pc.c | 47 smbios.c| 519 +++ smbios_types.h | 182

[Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines

2007-12-07 Thread Anthony Liguori
Ryan Harper wrote: * Anthony Liguori [EMAIL PROTECTED] [2007-12-07 14:49]: + +CPUState *first_cpu; This should probably be static. doh, should be extern actually since it's defined elsewhere. Perhaps you want cpu_single_env instead of first_cpu? Regards, Anthony